+1 (non-binding)

Completed all the steps of the helper guide and played with the demo app. 
Verified the LN and Readme. Also verified version strings in the latest RC 3.

Nice work on this everyone and thanks for RM'ing this initial release, Scott!

Thanks,
Kevin

On 6/12/18, 10:12, "Matt Gilman" <matt.c.gil...@gmail.com> wrote:

    +1 binding
    
    Ran through helper guide. Verified signatures, hashes, build, etc. Version
    strings look better with this RC. Provided other feedback regarding
    improvements to the demo app during RC1.
    
    Thanks for RMing this Scott!
    
    Matt
    
    On Tue, Jun 12, 2018 at 8:28 AM, Rob Moran <rmo...@gmail.com> wrote:
    
    > +1
    >
    > * Stepped through the release guide to verify the sig, hashes, and commit
    > ID
    > * Checked for readme, notice, and license in source and target
    > * Checked for the package version update changes
    > * Ran the demo app – seems to be a slight delay initially loading up but
    > all looks good
    >
    > Thanks for all your effort on this, Scott!
    >
    >
    > On Tue, Jun 12, 2018 at 2:59 AM Pierre Villard <
    > pierre.villard...@gmail.com>
    > wrote:
    >
    > > +1, binding
    > >
    > > Went through the release helper guide and all looks good to me AFAICT.
    > > I merged the PR from Andy and set the fix version to 0.2.0.
    > > (could be a good idea to ask infra for a dedicated JIRA so we don't mix
    > > things regarding version numbers?)
    > >
    > > Congrats on this first release and thanks to everyone involved!
    > >
    > > Pierre
    > >
    > > 2018-06-12 1:02 GMT+02:00 Andy LoPresto <alopre...@apache.org>:
    > >
    > > > Verified the GPG signature (SHA-512 digest, excellent) and checksums.
    > > > Ran through the build and deployed, testing the demo app.
    > > > Verified the LICENSE, NOTICE, and README in the source and deployable
    > > > application.
    > > > Checked the versioning in package.json and package-lock.json (not a
    > > > JS/node expert, but I think it’s right).
    > > >
    > > > (One tiny typo in the README, which I fixed in a PR).
    > > >
    > > > +1, binding
    > > >
    > > > Thanks for your continued work on this release, Scott.
    > > >
    > > >
    > > > Andy LoPresto
    > > > alopre...@apache.org
    > > > *alopresto.apa...@gmail.com <alopresto.apa...@gmail.com>*
    > > > PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4  BACE 3C6E F65B 2F7D EF69
    > > >
    > > > On Jun 11, 2018, at 1:50 PM, Scott Aslan <scottyas...@gmail.com>
    > wrote:
    > > >
    > > > Hello,
    > > >
    > > >
    > > > I am pleased to be calling this vote for the source release of Apache
    > > >
    > > > NiFi Flow Design System 0.1.0.
    > > >
    > > >
    > > > The source zip, including signatures, etc. can be found at:
    > > >
    > > > https://dist.apache.org/repos/dist/dev/nifi/nifi-fds/nifi-fds-0.1.0/
    > > >
    > > >
    > > > The Git tag is nifi-fds-0.1.0-RC3
    > > >
    > > > The Git commit ID is 4f62f3d4a4626f66011289c7f1346c082a932184
    > > >
    > > > *https://git-wip-us.apache.org/repos/asf?p=nifi-fds.git;a=
    > > > commit;h=4f62f3d4a4626f66011289c7f1346c082a932184
    > > > <https://git-wip-us.apache.org/repos/asf?p=nifi-fds.git;a=
    > > > commit;h=4f62f3d4a4626f66011289c7f1346c082a932184>*
    > > >
    > > >
    > > > Checksums of nifi-fds-0.1.0-source-release.zip:
    > > >
    > > > SHA1:
    > > >
    > > > ce971d78cc0660299dcee2233bc22fa78e2940af
    > > >
    > > > SHA256:
    > > >
    > > > 7cb36f412b4147c0e071508f4f6d2ca76b2fe524382937d6552dbe7efe10a827
    > > >
    > > > SHA512:
    > > >
    > > > 11e9cf4a529862da528bd616124e57f567503c25820e4b70e72d3d53f16b
    > > > fed7c0c97f05f7c390267d2163cdae2c6151dc6d9a9bdf6c11be8a6dca4409b3bd15
    > > >
    > > >
    > > > Release artifacts are signed with the following key:
    > > >
    > > > https://people.apache.org/keys/committer/scottyaslan.asc
    > > >
    > > >
    > > > KEYS file available here:
    > > >
    > > > https://dist.apache.org/repos/dist/release/nifi/KEYS
    > > >
    > > >
    > > > 7 issues were closed/resolved for this release:
    > > >
    > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
    > > > ctId=12316020&version=12343357
    > > >
    > > >
    > > > Release note highlights can be found here:
    > > >
    > > > https://cwiki.apache.org/confluence/display/NIFI/Release+
    > > > Notes#ReleaseNotes-NiFiFlowDesignSystem0.1.0
    > > >
    > > >
    > > > The vote will be open for 72 hours.
    > > >
    > > >
    > > > Please download the release candidate and evaluate the necessary items
    > > >
    > > > including checking hashes, signatures, build from source, and test.
    > > >
    > > >
    > > > The please vote:
    > > >
    > > >
    > > > [ ] +1 Release this package as nifi-fds-0.1.0
    > > >
    > > > [ ] +0 no opinion
    > > >
    > > > [ ] -1 Do not release this package because...
    > > >
    > > >
    > > >
    > >
    >
    


Reply via email to