Mike, No, there's a NullPointerException within groovy-eclipse-compiler during the test compile phase. Part of what I'm doing is trying to encapsulate everything into a profile that activates when a version of Java higher than 1.8 is being used to build. I'm not a Maven wizard, but overriding/excluding some of the dependencies and plugin configurations that are in the POMs is somewhat difficult. My lack of Maven knowledge might be biting me here, and it could've been a configuration thing, but I couldn't get groovy-eclipse-compiler to build all the tests.
I worked for a while trying to get the gmaven-plus plugin to compile the groovy code and eventually got it to work. I still have some things to check/test/do, but hopefully within a day or two I'll have a PR up if you're interesting in reviewing it. The hardest part (I hope!) is done, with the build completing successfully, albeit with the tests skipped. Tomorrow I'll be at it again, letting the build run through with the tests. Once that's successful, I am going to work on some changes to the POMs outside of the profiles I created for compiling on Java versions newer than 1.8, and tidy everything up. I may look into switching the Java 1.8 build to use gmaven-plus, as well, which would simplify things between Java 1.8 and Java 10+. One of the things I did was push the groovy dependencies down into the modules that actually use them, rather than having the parent NiFi pom define a test dependency on groovy-all. There's a good deal of POM clean-up we could do... Working on this PR has helped (or forced :)) me to learn a bit more about Maven and some best-practices that we could implement in the POMs. On Mon, Jun 18, 2018 at 4:14 PM Mike Thomsen <[email protected]> wrote: > I'm guessing they were probably Spock tests. Is that right? > > On Mon, Jun 18, 2018 at 3:06 PM Jeff <[email protected]> wrote: > > > Mike, > > > > I'm working on NIFI-5176 [1] and will try switching to GMavenPlus. I've > > been running into issues with compiling Groovy tests with > > groovy-eclipse-maven, and it'd be nice if switching the plugin would > help. > > I'll report back with my hopeful success! > > > > [1] https://issues.apache.org/jira/browse/NIFI-5176 > > > > On Sat, Jun 16, 2018 at 12:24 PM Mike Thomsen <[email protected]> > > wrote: > > > > > I just noticed that the Registry appears to use GMavenPlus while NiFi > > > itself uses the eclipse Groovy compiler plugin. GMavenPlus also appears > > to > > > have no problems working with Groovy 2.5.0 while the eclipse compiler > > only > > > supports it in snapshot builds. Does anyone know a compelling reason to > > not > > > move NiFi over to using GMavenPlus for Groovy compiler support? > > > > > >
