+1, binding

- verified build on Mac OS X 10.14 and Alpine Linux (using docker build)
- exercised various new features including JNI processors and CoAP support

I did observe a minor issue using the bootstrap script on Mac [1] for
which I submitted [2].

All in all, really great release -- amazing how far the C++ agent has
come. Great work everyone and thanks for RM'ing Marc!

[1] https://issues.apache.org/jira/browse/MINIFICPP-783
[2] https://github.com/apache/nifi-minifi-cpp/pull/519

Thanks,
Kevin

On Thu, Mar 21, 2019 at 10:15 PM Jeremy Dyer <[email protected]> wrote:
>
> +1, binding
>
>    - Verified all checksums
>    - Configured via CMake without bootstrap.sh
>    - Configured and built with bootstrap.sh
>    - Validated base build
>    - Validated build with all extensions enabled on CentOs 7.6 and Ubuntu
>    18.04
>    - Validated base build on OS X 10.14.3
>    - Validated base build on Ubuntu 16.04
>    - Validated base build on Ubuntu 18.04
>    - Verified LICENSE and README look good
>
> Thank you for getting this RC together. I have for one have been following
> this release closely and am very excited for the new JNI integrations,
> native Python processors, and CoAP support.
>
> On Wed, Mar 20, 2019 at 8:10 AM Arpad Boda <[email protected]> wrote:
>
> > +1
> >
> >
> >
> > -Verified checksums, signature, commit ID
> >
> > -Built on Ubuntu 16 and OS X 10.13 (executed all tests on both systems)
> >
> > -Verified MiNiFi and some Nanofi examples to start and work as expected
> >
> > -LICENSE found a looks good to me
> >
> > -NOTICE found, but should be updated:
> >
> > Apache NiFi MiNiFi
> >
> > Copyright 2017 The Apache Software Foundation
> >
> > -README.md found a looks good to me, contains a minor typo for Bionic:
> >
> > | Ubuntu 16  | make u18 | nifi-minifi-cpp-bionic-$VERSION-bin.tar.gz
> >
> >
> >
> >
> >
> > On 19/03/2019, 20:59, "Aldrin Piri" <[email protected]> wrote:
> >
> >
> >
> >     +1, binding
> >
> >
> >
> >     So much great stuff in this release.  Thanks for RMing, Marc!
> >
> >
> >
> >     comments:
> >
> >     Signature and hashes looked good
> >
> >     Verified build, tests, and linter looked good on Ubuntu 18 and OS X
> > 10.13
> >
> >     Performed builds using the make targets {u16, u18, centos, debian,
> > fedora}
> >
> >     to generate successful assemblies
> >
> >     Verified a sampling of the assemblies on different platforms and
> > worked as
> >
> >     expected for a variety of flows and functionalities
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >     On Tue, Mar 19, 2019 at 12:52 PM Marc Parisi <[email protected]>
> > wrote:
> >
> >
> >
> >     > Hello Apache NiFi community,
> >
> >     >
> >
> >     > I am pleased to call this vote for the source release of Apache NiFi
> > MiNiFi
> >
> >     > C++ 0.6.0
> >
> >     >
> >
> >     > The source tar.gz, including signatures, digests, and convenience
> > binaries.
> >
> >     > can be found at:
> >
> >     >
> > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/0.6.0-rc2/
> >
> >     >
> >
> >     > The Git tag is minifi-cpp-0.6.0-RC2
> >
> >     > The Git commit ID is 28ade6cf75e8a0ccce78699f147f4ad9baaf70c2
> >
> >     >
> > https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;a=commit;h=
> >
> >     > <
> >
> >     >
> > https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;a=commit;h=28ade6cf75e8a0ccce78699f147f4ad9baaf70c2
> >
> >     > >
> >
> >     > 28ade6cf75e8a0ccce78699f147f4ad9baaf70c2
> >
> >     >
> >
> >     > Checksum of nifi-minifi-cpp-0.6.0-source.tar.gz:
> >
> >     > SHA256:
> > 65c5ecf4b8ce807e982ed4dcb11472f574f62e66bfeeaa3348b0852c926175c3
> >
> >     > SHA512:
> >
> >     >
> >
> >     >
> > 4c53275b6b595fe1a17f6ad54a4aaa831b45044f3f8a5ad204475d3beb8fde441fc28d4a385d8804ed28f7934e37d45a01ab130b5241baa414a7c788f23e4451
> >
> >     >
> >
> >     > Release artifacts are signed with the following key:
> >
> >     > https://people.apache.org/keys/committer/phrocker.asc
> >
> >     >
> >
> >     > KEYS file available here:
> >
> >     > https://dist.apache.org/repos/dist/release/nifi/KEYS
> >
> >     >
> >
> >     > 142 issues were closed/resolved for this release:
> >
> >     >
> >
> >     >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321520&version=12343363
> >
> >     >
> >
> >     > Release note highlights can be found here:
> >
> >     >
> >
> >     >
> > https://cwiki.apache.org/confluence/display/MINIFI/Release+Notes#ReleaseNotes-Versioncpp-0.6.0
> >
> >     >
> >
> >     > The vote will be open for 72 hours.
> >
> >     > Please download the release candidate and evaluate the necessary
> > items
> >
> >     > including checking hashes, signatures, build
> >
> >     > from source, and test.  The please vote:
> >
> >     >
> >
> >     > [ ] +1 Release this package as nifi-minifi-cpp-0.6.0
> >
> >     > [ ] +0 no opinion
> >
> >     > [ ] -1 Do not release this package because because...
> >
> >     >
> >
> >
> >

Reply via email to