-1 (binding) The LICENSE and NOTICE need some changes. They're arguably minor but lets take this opportunity to fix it. For dependencies which are ALv2 you do not need to copy/paste their LICENSE text in and in fact ALv2 dependencies should not even be referenced in the LICENSE. They may require referencing in the NOTICE file if they have copyright/NOTICE considerations to carry forward. I can work with you on that Scott. See http://nifi.apache.org/licensing-guide.html
Otherwise, things look good. Am able to build locally and review the demo application. I didn't yet verify sigs/hashes. Thanks Joe On Tue, Jul 23, 2019 at 12:25 PM Robert Fellows <[email protected]> wrote: > * Verified the signature > * Verified the hashes > * Build was successful > * Demo app works as expected > > I also npm link'd the new @nifi-fds/core in NiFi-Registry to verify it will > work. > However, it wasn't clear in the README that it requires upgrading > dependencies in the consuming app (angular, rxjs, angular-material, ...). > Once those changes were made, it worked. I think it worth documenting that > in the README and/or the Wiki. I created a JIRA for it > https://issues.apache.org/jira/browse/NIFI-6474. > > With that caveat: > +1 (non-binding) Release this package as nifi-fds-0.2.0 > > -- Rob > > > On Mon, Jul 22, 2019 at 7:19 PM Scott Aslan <[email protected]> wrote: > > > Hello, > > > > > > I am pleased to be calling this vote for the source release of Apache > > > > NiFi Flow Design System 0.2.0. > > > > > > The source zip, including signatures, etc. can be found at: > > > > https://dist.apache.org/repos/dist/dev/nifi/nifi-fds/nifi-fds-0.2.0/ > > > > > > The Git tag is NIFI-FDS-0.2.0-RC1 > > > > The Git commit ID is cee69170d68db602b8acac0959ee9e91c1000599 > > > > > > > https://git-wip-us.apache.org/repos/asf?p=nifi-fds.git;a=commit;h=cee69170d68db602b8acac0959ee9e91c1000599 > > > > > > Checksums of nifi-fds-0.2.0-source-release.zip: > > > > SHA1: 14e8f3e908ec0ddd3556ee52524c2a5a099b4370 > > > > SHA256: ae92eebf2d0b818b44203c896cde95e8c0dbf9007f9d3909e0253b156cf4b102 > > > > SHA512: > > > > > 86940d676ff63b7f23762dc4c3fc48ed19e1e67e97f4606cebce31b7f6b0976c60da487f6d23ce9476a293fb8fb790bfbaa3a8f1cfee5c8797658ac00718c3d9 > > > > > > Release artifacts are signed with the following key: > > > > https://people.apache.org/keys/committer/scottyaslan.asc > > > > > > KEYS file available here: > > > > https://dist.apache.org/repos/dist/release/nifi/KEYS > > > > > > 36 issues were closed/resolved for this release: > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12343453&projectId=12316020 > > > > > > Release note highlights can be found here: > > > > > > > https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-NiFiFlowDesignSystem0.2.0 > > > > > > The vote will be open for 72 hours. > > > > > > Please download the release candidate and evaluate the necessary items > > > > including checking hashes, signatures, build from source, and test. > > > > > > The please vote: > > > > > > [ ] +1 Release this package as nifi-fds-0.2.0 > > > > [ ] +0 no opinion > > > > [ ] -1 Do not release this package because... > > > > > -- > ------------------------------- > Rob Fellows >
