+1 (binding) Full clean build following readme and testapp check out. L&N looks good. Sigs/Commit checks out.
I would recommend ditching the sha1 entry. 256 and 512 are good. Thanks On Fri, Jul 26, 2019 at 1:33 PM Marc Parisi <phroc...@apache.org> wrote: > +1 (binding). I built and tested according to the release helper guide. > Demo app, hashes, readmes, and notices all look good. > > Thanks Scott! > > On Fri, Jul 26, 2019 at 10:09 AM Matt Gilman <matt.c.gil...@gmail.com> > wrote: > > > +1 (binding) Release this package as nifi-fds-0.2.0 > > > > Ran through release helper. Checked out demo app and all looks good. > > > > Thanks for RMing Scott! > > > > Matt > > > > On Wed, Jul 24, 2019 at 7:15 AM Kovacs Andras > <and...@cloudera.com.invalid > > > > > wrote: > > > > > * Verified the signature > > > * Verified the hashes > > > * Verified README > > > * Verified the demo app works as expected > > > > > > Unfortunately majority of npm scripts are broken on windows, however I > > > could make them run and test the app with some minor changes. JIRA > issue: > > > https://issues.apache.org/jira/browse/NIFI-6481 > > > > > > + 1 (non-binding) > > > > > > András > > > > > > On Wed, Jul 24, 2019 at 11:41 AM Adam Kocsis > > <akoc...@cloudera.com.invalid > > > > > > > wrote: > > > > > > > * Verified the git commit > > > > * Verified the signature > > > > * Verified the hashes > > > > * Verified the build > > > > * Verified README > > > > * Verified the demo app works as expected > > > > > > > > + 1 (non-binding) > > > > > > > > Cheers, > > > > Adam > > > > > > > > On Wed, Jul 24, 2019 at 3:33 AM Robert Fellows < > rob.fell...@gmail.com> > > > > wrote: > > > > > > > > > * Verified the signature > > > > > * Verified the hashes > > > > > * Verified the build > > > > > * Verified README > > > > > * Verified the demo app works as expected > > > > > * Successfully npm link'd @nifi-fds/core in nifi-registry, worked > > with > > > > > documented updates. > > > > > > > > > > + 1 (non-binding) > > > > > > > > > > > > > > > -- Rob Fellows > > > > > > > > > > On Tue, Jul 23, 2019 at 4:07 PM Scott Aslan <scottyas...@gmail.com > > > > > > wrote: > > > > > > > > > > > Hello, > > > > > > > > > > > > > > > > > > I am pleased to be calling this vote for the source release of > > Apache > > > > > > > > > > > > NiFi Flow Design System 0.2.0. > > > > > > > > > > > > > > > > > > The source zip, including signatures, etc. can be found at: > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/nifi/nifi-fds/nifi-fds-0.2.0/ > > > > > > > > > > > > > > > > > > The Git tag is NIFI-FDS-0.2.0-RC2 > > > > > > > > > > > > The Git commit ID is 0b2443fce830a69f45c2d096872f84871e814d17 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=nifi-fds.git;a=commit;h=0b2443fce830a69f45c2d096872f84871e814d17 > > > > > > > > > > > > > > > > > > Checksums of nifi-fds-0.2.0-source-release.zip: > > > > > > > > > > > > SHA1: d11a7bbd4bcb1a9fc09f69d0a87ba3c26c20318d > > > > > > > > > > > > SHA256: > > > > 6dd0d9f9e09e57c85ea435e282118b1289fe7ebbeb6cd987aeeafc895815431f > > > > > > > > > > > > SHA512: > > > > > > > > > > > > > > > > > > > > > > > > > > > 34110b6f06c2bd21696a83f69f7d0d6840b669408e4c12cf0a6101b6596e977fa4dfb4b62ade5104f4ad7df369a278535e4bb6b65fb89dd793140d748f70c0d1 > > > > > > > > > > > > > > > > > > Release artifacts are signed with the following key: > > > > > > > > > > > > https://people.apache.org/keys/committer/scottyaslan.asc > > > > > > > > > > > > > > > > > > KEYS file available here: > > > > > > > > > > > > https://dist.apache.org/repos/dist/release/nifi/KEYS > > > > > > > > > > > > > > > > > > 36 issues were closed/resolved for this release: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12343453&projectId=12316020 > > > > > > > > > > > > > > > > > > Release note highlights can be found here: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-NiFiFlowDesignSystem0.2.0 > > > > > > > > > > > > > > > > > > The vote will be open for 72 hours. > > > > > > > > > > > > > > > > > > Please download the release candidate and evaluate the necessary > > > items > > > > > > > > > > > > including checking hashes, signatures, build from source, and > test. > > > > > > > > > > > > > > > > > > The please vote: > > > > > > > > > > > > > > > > > > [ ] +1 Release this package as nifi-fds-0.2.0 > > > > > > > > > > > > [ ] +0 no opinion > > > > > > > > > > > > [ ] -1 Do not release this package because... > > > > > > > > > > > > > > > > > > > > > -- > > > > > ------------------------------- > > > > > Rob Fellows > > > > > > > > > > > > > > >
