Hi Jeff, yes, my issue is fixed with your PR!
Thanks, Marc On Wed, Aug 7, 2019 at 9:05 PM Jeff <[email protected]> wrote: > Marc, > > Your issue will most likely be resolved by NIFI-6529 [1], for which I > submitted PR 3639 [2]. If you get a chance, please check out PR 3639 and > run the tests as described in the PR. You can update user.language and > user.region in the mvn command line to use your particular locale. > > [1] https://issues.apache.org/jira/browse/NIFI-6529 > [2] https://github.com/apache/nifi/pull/3639 > > On Wed, Aug 7, 2019 at 10:40 AM Arpad Boda <[email protected]> wrote: > > > I think there are more of these: > > https://issues.apache.org/jira/browse/NIFI-5750 > > > > On Wed, Aug 7, 2019 at 7:54 AM Marc Pellmann <[email protected]> wrote: > > > > > Hi Pierre, > > > > > > thank you for your reply! It should be reproduce-able with setting the > > > german locale in the pom: > > > > > > <maven.surefire.arguments>-Duser.language=de -Duser.country=DE > > > -Duser.region=DE</maven.surefire.arguments> > > > > > > Thanks, > > > Marc > > > > > > On Wed, Aug 7, 2019 at 1:21 PM Pierre Villard < > > [email protected] > > > > > > > wrote: > > > > > > > I filed a JIRA NIFI-6531 [1], and will look into it. > > > > > > > > [1] https://issues.apache.org/jira/browse/NIFI-6531 > > > > > > > > Le mer. 7 août 2019 à 11:37, Pierre Villard < > > [email protected] > > > > > > > > a > > > > écrit : > > > > > > > > > Hi Marc, > > > > > > > > > > This should not happen as we are trying to have a build locale > > > agnostic. > > > > > If you can list the failing tests and/or file a JIRA, that would be > > > > > awesome. I'll definitely have a look on my side. > > > > > > > > > > The workaround you suggested about modifying the pom for the > surefire > > > > > plugin is the best way to go AFAIK. > > > > > > > > > > Thanks, > > > > > Pierre > > > > > > > > > > > > > > > Le mer. 7 août 2019 à 11:05, Marc Pellmann <[email protected]> a > > > écrit > > > > : > > > > > > > > > >> Hi, > > > > >> > > > > >> I tried to build NiFi from source and had some problems with my > > german > > > > >> OS(X). Some tests did not passed because there have been errors > > with . > > > > vs > > > > >> , > > > > >> in the tests. > > > > >> > > > > >> Example: > > > > >> > > > > >> [ERROR] > > testFormatDataSize(org.apache.nifi.processor.TestFormatUtils) > > > > >> Time > > > > >> elapsed: 0.004 s <<< FAILURE! org.junit.ComparisonFailure: > > > > >> expected:<10[.]4 > > > > >> bytes> but was:<10[,]4 bytes> at > > > > >> > > > > >> > > > > > > > > > > org.apache.nifi.processor.TestFormatUtils.testFormatDataSize(TestFormatUtils.java:91) > > > > >> > > > > >> Of course it works when I switch my OS to english/US, but that is > > not > > > > >> really a solution. To set this with system variables like > > > > >> JAVA_TOOL_OPTIONS > > > > >> with -Duser.language=en -Duser.country=US -Duser.region=US did not > > > > worked. > > > > >> > > > > >> The only solution was to set it in the pom.xml for the surefire > > plugin > > > > >> directly: > > > > >> > > > > >> <maven.surefire.arguments>-Duser.language=en -Duser.country=US > > > > >> -Duser.region=US</maven.surefire.arguments> > > > > >> > > > > >> Is there a different solution? Or if not - shouldn't this be the > > > > default? > > > > >> > > > > >> Thanks, > > > > >> > > > > >> Marc > > > > >> > > > > > > > > > > > > > > >
