-1 (binding) Was able to verify commit hashes. Build completed but did have some problems with the unit tests. I had failures in the KnoxServiceTest (error output below [4]). I've never seen these errors before, but this is the first time in quite a while that I deleted my entire .m2 repository before building - it may (or may not) be related.
When I skipped the test, the build continued on. I did run into another issue during the build, though: [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.4:install-node-and-npm (install-node-and-npm) on project nifi-web-ui: Could not extract the Node archive: Could not extract archive: '/Users/mpayne/.m2/repository/com/github/eirslett/node/8.10.0/node-8.10.0-darwin-x64.tar.gz': EOFException -> [Help 1] I tried to fetch the file using wget as well, but it also failed. It appears that the problem was the web server, not the NiFi build. Interestingly, I was able to successfully download the file using Chrome by going to https://nodejs.org/dist/v8.10.0/node-v8.10.0-darwin-x64.tar.gz and putting the downloaded file into my .m2 repository manually. Given these 2 issues, I would still veer toward a +1 (given that I've not seen the unit test failures and haven't seen others run into the issue, including Travis, so it may just be an environmental issue, and the other is not a problem with NiFi). In testing, though, I did run into a few bugs [1][2][3]. NIFI-6807 [3] I think is pretty critical. It resulted in nodes being kicked out of the cluster. While I believe this actually affects 1.9.x also, now that we know about it, I think it's worthy of a -1. I did mark the ticket as Critical with a fix version of 1.11.0, though, in case others disagree. NIFI-6805 [1] and NIFI-6806 [2] were not quite as critical but did make it very difficult to track down exactly what was happening when I encountered NIFI-6807. Thanks -Mark [1] https://issues.apache.org/jira/browse/NIFI-6805 [2] https://issues.apache.org/jira/browse/NIFI-6806 [3] https://issues.apache.org/jira/browse/NIFI-6807 [4] Errors from Knox Service Test: [ERROR] Tests run: 8, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 2.367 s <<< FAILURE! - in org.apache.nifi.web.security.knox.KnoxServiceTest [ERROR] testExpiredJwt(org.apache.nifi.web.security.knox.KnoxServiceTest) Time elapsed: 2.085 s <<< ERROR! java.lang.Exception: Unexpected exception, expected<org.apache.nifi.web.security.InvalidAuthenticationException> but was<java.lang.IllegalArgumentException> at org.apache.nifi.web.security.knox.KnoxServiceTest.testExpiredJwt(KnoxServiceTest.java:161) [ERROR] testBadSignedJwt(org.apache.nifi.web.security.knox.KnoxServiceTest) Time elapsed: 0.088 s <<< ERROR! java.lang.Exception: Unexpected exception, expected<org.apache.nifi.web.security.InvalidAuthenticationException> but was<java.lang.IllegalArgumentException> at org.apache.nifi.web.security.knox.KnoxServiceTest.testBadSignedJwt(KnoxServiceTest.java:116) [ERROR] testInvalidAudience(org.apache.nifi.web.security.knox.KnoxServiceTest) Time elapsed: 0.02 s <<< ERROR! java.lang.Exception: Unexpected exception, expected<org.apache.nifi.web.security.InvalidAuthenticationException> but was<java.lang.IllegalArgumentException> at org.apache.nifi.web.security.knox.KnoxServiceTest.testInvalidAudience(KnoxServiceTest.java:200) [ERROR] testRequiredAudience(org.apache.nifi.web.security.knox.KnoxServiceTest) Time elapsed: 0.025 s <<< ERROR! java.lang.IllegalArgumentException: The RSA key size must be at least 2048 bits at org.apache.nifi.web.security.knox.KnoxServiceTest.testRequiredAudience(KnoxServiceTest.java:180) [ERROR] testSignedJwt(org.apache.nifi.web.security.knox.KnoxServiceTest) Time elapsed: 0.034 s <<< ERROR! java.lang.IllegalArgumentException: The RSA key size must be at least 2048 bits at org.apache.nifi.web.security.knox.KnoxServiceTest.testSignedJwt(KnoxServiceTest.java:93) On Oct 22, 2019, at 12:33 PM, Joe Witt <[email protected]<mailto:[email protected]>> wrote: Hello, I am pleased to be calling this vote for the source release of Apache NiFi nifi-1.10.0. The source zip, including signatures, digests, etc. can be found at: https://repository.apache.org/content/repositories/orgapachenifi-1148 The Git tag is nifi-1.10.0-RC1 The Git commit ID is 9962821b0d649be8ad0ed9b5383db903968c4d37 https://gitbox.apache.org/repos/asf?p=nifi.git;a=commit;h=9962821b0d649be8ad0ed9b5383db903968c4d37 Checksums of nifi-1.10.0-source-release.zip: SHA256: b6c53b5298ff8aa92b186ce17e30880b9c7d7877cc0849a0ca05df8f1f9ac667 SHA512: 90a6491d01a0c4589ee61b9f1313a99d04e3c602c4ced561ccafdf8aacf3ed4d1a42f985ea9b4bcbb3dced0a089582ca3def5d8d831f0dcbb5d61cce1d16d6c3 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/joewitt.asc KEYS file available here: https://dist.apache.org/repos/dist/release/nifi/KEYS 366 issues were closed/resolved for this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12344993 Release note highlights can be found here: https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.10.0 The vote will be open for 72 hours. Please download the release candidate and evaluate the necessary items including checking hashes, signatures, build from source, and test. Then please vote: [ ] +1 Release this package as nifi-1.10.0 [ ] +0 no opinion [ ] -1 Do not release this package because...
