+1 (binding)
Everything in release helper checked out. I did run into a test
failure the first time building the source, but then trying again
succeeded. I think it is a sporadic failure we have seen before...
[ERROR] Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time
elapsed: 1.415 s <<< FAILURE! - in
org.apache.nifi.wali.TestLengthDelimitedJournal
[ERROR]
testFailureDuringWriteCannotCauseCorruption(org.apache.nifi.wali.TestLengthDelimitedJournal)
Time elapsed: 1.022 s <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<2>
at
org.apache.nifi.wali.TestLengthDelimitedJournal.testFailureDuringWriteCannotCauseCorruption(TestLengthDelimitedJournal.java:585)
On Thu, Oct 31, 2019 at 6:42 AM Kotaro Terada <[email protected]> wrote:
>
> Thanks for taking care of it, Pierre and Joe!
>
> > Please note only PMC votes are binding.
>
> I got it, I'll be careful next time.
>
> Thanks,
> Kotaro
>
>
> On Thu, Oct 31, 2019 at 7:32 PM Joe Witt <[email protected]> wrote:
>
> > Id just flag this on release notes and we can fix for the next release.
> >
> > Kotaro good find. Please note only PMC votes are binding.
> >
> > Thanks
> >
> > On Thu, Oct 31, 2019 at 6:27 AM Pierre Villard <
> > [email protected]>
> > wrote:
> >
> > > Good catch Kotaro! I merged the fix for #2. The fix for #1 LGTM but I'll
> > > let the guys who worked on the Java 11 bits look into it.
> > >
> > > Joe, I didn't set the fix version on the JIRA and will wait until we
> > reach
> > > a decision regarding this RC.
> > >
> > > Le jeu. 31 oct. 2019 à 11:08, Kotaro Terada <[email protected]> a
> > écrit :
> > >
> > > > -1 (binding), due to the following problems I found.
> > > >
> > > > (1) NiFi doesn't start up from the rpm build on Java 11.
> > > >
> > > > We have a mismatch in the "lib" directories of rpm and non-rpm build.
> > > This
> > > > causes that NiFi (with Java 11) doesn't start up from the rpm build.
> > Some
> > > > jar files should be located in the "lib/bootstrap/" but they are
> > > currently
> > > > in "lib/".
> > > >
> > > > I checked the following behaviors:
> > > > - Non-RPM (usual) build with Java 8 and run on Java 8... OK
> > > > - Non-RPM (usual) build with Java 11 and run on Java 11... OK
> > > > - RPM build with Java 8 and run on Java 8... OK (isn't affected by the
> > > lib
> > > > mismatch)
> > > > - RPM build with Java 11 and run on Java 11... NiFi doesn't start (this
> > > > problem)
> > > >
> > > > I created a JIRA and a PR to fix it:
> > > > https://issues.apache.org/jira/browse/NIFI-6827
> > > >
> > > > (2) There is an unintentional string in "conf/logback.xml".
> > > >
> > > > The "conf/logback.xml" seems to have an unintentional string
> > > > "MockProcessContext". I guess this was slipped into it by the merging
> > > > commit of https://github.com/apache/nifi/pull/3773 unintentionally.
> > > >
> > > > I created a JIRA and a PR to fix it:
> > > > https://issues.apache.org/jira/browse/NIFI-6828
> > > >
> > > > Could you take a look at them, please?
> > > >
> > > > Thanks for working for the release!
> > > > Kotaro
> > > >
> > > >
> > > > On Thu, Oct 31, 2019 at 6:10 PM Pierre Villard <
> > > > [email protected]>
> > > > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > Went through the release helper guide and it LGTM. Deployed
> > > > > secured/unsecured standalone/cluster instances on Google Cloud with
> > > > various
> > > > > flows including the new BigQuery processor and everything is looking
> > > > good.
> > > > >
> > > > > Thanks Joe for taking care of the release!
> > > > >
> > > > > Pierre
> > > > >
> > > > > Le jeu. 31 oct. 2019 à 03:12, Shayne Burgess <
> > [email protected]
> > > >
> > > > a
> > > > > écrit :
> > > > >
> > > > > > +1 (non-binding)
> > > > > >
> > > > > > Deployed cluster in Azure and smoke tested a fairly complicated
> > data
> > > > > flow.
> > > > > >
> > > > > > Verified the fixes for the Azure EventHub Processor that were
> > pulled
> > > > into
> > > > > > RC3 are working as expected.
> > > > > >
> > > > > > Shayne
> > > > > >
> > > > > > On Wed, Oct 30, 2019 at 5:59 PM Jeff Zemerick <
> > [email protected]>
> > > > > > wrote:
> > > > > >
> > > > > > > +1 (non-binding)
> > > > > > >
> > > > > > > Built and ran successfully and built custom processor with 1.10.0
> > > > > > > dependency and successfully uploaded NAR to NiFi Registry 0.5.0.
> > > > > > >
> > > > > > > On Wed, Oct 30, 2019 at 4:06 PM Mark Payne <[email protected]
> > >
> > > > > wrote:
> > > > > > >
> > > > > > > > +1 (binding)
> > > > > > > >
> > > > > > > > Was able to build and verify that all of the Jiras that I
> > raised
> > > > last
> > > > > > > time
> > > > > > > > around have been addressed in this RC. Left a cluster of 10
> > nodes
> > > > > > running
> > > > > > > > for a day or two, pretty heavily taxed, and ran into no issues.
> > > > > > > >
> > > > > > > > Thanks
> > > > > > > > -Mark
> > > > > > > >
> > > > > > > >
> > > > > > > > > On Oct 30, 2019, at 3:20 PM, Matt Gilman <
> > > > [email protected]>
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > +1 (binding)
> > > > > > > > >
> > > > > > > > > Verified signatures, hashes, build, etc. Tested both
> > standalone
> > > > and
> > > > > > > > > clustered and secure and unsecured.
> > > > > > > > >
> > > > > > > > > Thanks for RMing Joe!
> > > > > > > > >
> > > > > > > > > Matt
> > > > > > > > >
> > > > > > > > > On Wed, Oct 30, 2019 at 1:51 PM Adam Taft <[email protected]
> > >
> > > > > wrote:
> > > > > > > > >
> > > > > > > > >> +1 (binding)
> > > > > > > > >>
> > > > > > > > >> Signatures verified.
> > > > > > > > >> Hashes verified.
> > > > > > > > >> Tests pass, source builds cleanly.
> > > > > > > > >> I used both Java 11 & Java 8 to build.
> > > > > > > > >>
> > > > > > > > >> I did run into a problem compiling with Java 11 and running
> > > with
> > > > > > Java
> > > > > > > > 8. I
> > > > > > > > >> don't believe this was a goal of the Java 11 compatibility
> > > > > changes,
> > > > > > so
> > > > > > > > >> nothing unexpected about this. But it's possibly worth
> > > > discussion
> > > > > in
> > > > > > > > >> another thread (which I'll send out). The convenience
> > binary
> > > > was
> > > > > > > > compiled
> > > > > > > > >> with Java 8, so no problems with compatibility either way.
> > > > > > > > >>
> > > > > > > > >> On Tue, Oct 29, 2019 at 11:32 AM Joe Witt <
> > [email protected]
> > > >
> > > > > > wrote:
> > > > > > > > >>
> > > > > > > > >>> Hello,
> > > > > > > > >>>
> > > > > > > > >>> I am pleased to be calling this vote for the source release
> > > of
> > > > > > Apache
> > > > > > > > >> NiFi
> > > > > > > > >>> nifi-1.10.0.
> > > > > > > > >>>
> > > > > > > > >>> As they say 'third time's a charm'.
> > > > > > > > >>>
> > > > > > > > >>> The source zip, including signatures, digests, etc. can be
> > > > found
> > > > > > at:
> > > > > > > > >>>
> > > > > > >
> > > > https://repository.apache.org/content/repositories/orgapachenifi-1151
> > > > > > > > >>>
> > > > > > > > >>> The source being voted upon and the convenience binaries
> > can
> > > be
> > > > > > found
> > > > > > > > at:
> > > > > > > > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-1.10.0/
> > > > > > > > >>>
> > > > > > > > >>> The Git tag is nifi-1.10.0-RC3
> > > > > > > > >>> The Git commit ID is
> > b217ae20ad6a04cac874b2b00d93b7f7514c0b88
> > > > > > > > >>>
> > > > > > > > >>>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://gitbox.apache.org/repos/asf?p=nifi.git;a=commit;h=b217ae20ad6a04cac874b2b00d93b7f7514c0b88
> > > > > > > > >>>
> > > > > > > > >>> Checksums of nifi-1.10.0-source-release.zip:
> > > > > > > > >>> SHA256:
> > > > > > > >
> > e9b0a14b3029acd69c6693781b6b6487c14dda12676db8b4a015bce23b1029c1
> > > > > > > > >>> SHA512:
> > > > > > > > >>>
> > > > > > > > >>>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > b07258cbc21d2e529a1aa3098449917e2d059e6b45ffcfcb6df094931cf16caa8970576555164d3f2290cfe064b5780ba1a8bf63dad04d20100ed559a1cfe133
> > > > > > > > >>>
> > > > > > > > >>> Release artifacts are signed with the following key:
> > > > > > > > >>> https://people.apache.org/keys/committer/joewitt.asc
> > > > > > > > >>>
> > > > > > > > >>> KEYS file available here:
> > > > > > > > >>> https://dist.apache.org/repos/dist/release/nifi/KEYS
> > > > > > > > >>>
> > > > > > > > >>> 384 issues were closed/resolved for this release:
> > > > > > > > >>>
> > > > > > > > >>>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12344993
> > > > > > > > >>>
> > > > > > > > >>> Release note highlights can be found here:
> > > > > > > > >>>
> > > > > > > > >>>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.10.0
> > > > > > > > >>>
> > > > > > > > >>> The vote will be open for 72 hours.
> > > > > > > > >>> Please download the release candidate and evaluate the
> > > > necessary
> > > > > > > items
> > > > > > > > >>> including checking hashes, signatures, build
> > > > > > > > >>> from source, and test. Then please vote:
> > > > > > > > >>>
> > > > > > > > >>> [ ] +1 Release this package as nifi-1.10.0
> > > > > > > > >>> [ ] +0 no opinion
> > > > > > > > >>> [ ] -1 Do not release this package because...
> > > > > > > > >>>
> > > > > > > > >>
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
