+1 (binding)
During build, I did run into a problem with unit tests:
[ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.399
s <<< FAILURE! - in
org.apache.nifi.web.security.oidc.StandardOidcIdentityProviderGroovyTest
[ERROR]
testConvertOIDCTokenToNiFiTokenShouldHandleBlankIdentityAndNoEmailClaim(org.apache.nifi.web.security.oidc.StandardOidcIdentityProviderGroovyTest)
Time elapsed: 0.265 s <<< FAILURE!
java.lang.AssertionError: Closure
org.apache.nifi.web.security.oidc.StandardOidcIdentityProviderGroovyTest$_testConvertOIDCTokenToNiFiTokenShouldHandleBlankIdentityAndNoEmailClaim_closure6@534c6767
should have failed with an exception of type java.net.ConnectException,
instead got Exception javax.net.ssl.SSLHandshakeException:
java.security.cert.CertificateException: No subject alternative DNS name
matching localhost found.
at
org.apache.nifi.web.security.oidc.StandardOidcIdentityProviderGroovyTest.testConvertOIDCTokenToNiFiTokenShouldHandleBlankIdentityAndNoEmailClaim(StandardOidcIdentityProviderGroovyTest.groovy:432)
However, this appears to be a problem with my local setup. Digging into the
code it’s attempting to make an HTTP Request to https://localhost/oidc/userInfo
I attempted the same request via curl and got a similar issue:
~ $ curl https://localhost/oidc/userInfo
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.htmlcurl failed to verify
the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
So it appears that somehow I’m not able to get a DNS name for “localhost”. Not
sure exactly what that means, but it definitely appears to be
environment-specific.
We might want to consider changing this from a Unit Test to an Integration
Test. But otherwise, all seems good.
Finished building without unit tests. Started up, verified some of the specific
1.12.0 features and 1.12.1 fixes. Didn’t notice any problems.
Thanks for putting this release together, Joe!
-Mark
On Sep 25, 2020, at 11:45 AM, Pierre Villard
<pierre.villard...@gmail.com<mailto:pierre.villard...@gmail.com>> wrote:
+1 (binding)
Went through usual verification steps.
Thanks Joe for RM'ing!
Le ven. 25 sept. 2020 à 13:30, Tony Kurc
<tk...@apache.org<mailto:tk...@apache.org>> a écrit :
+1 (binding)
Verified signature and hashes. Built without issue on ubuntu 18.04 x86_64
with openjdk11. Saw no issues with LICENSE or NOTICE.
Tony
On Wed, Sep 23, 2020, 6:10 PM Joe Witt
<joew...@apache.org<mailto:joew...@apache.org>> wrote:
Hello,
I am pleased to be calling this vote for the source release of Apache
NiFi
1.12.1.
The source zip, including signatures, digests, etc. can be found at:
https://repository.apache.org/content/repositories/orgapachenifi-1170
The source being voted upon and the convenience binaries can be found at:
https://dist.apache.org/repos/dist/dev/nifi/nifi-1.12.1/
A helpful reminder on how the release candidate verification process
works:
https://cwiki.apache.org/confluence/display/NIFI/How+to+help+verify+an+Apache+NiFi+release+candidate
The Git tag is nifi-1.12.1-RC2
The Git commit ID is accfaa3034fa5c3ef55d6402ac31e500247100f9
https://gitbox.apache.org/repos/asf?p=nifi.git;a=commit;h=accfaa3034fa5c3ef55d6402ac31e500247100f9
Checksums of nifi-1.12.1-source-release.zip:
SHA256: 7735c632c6795bb0d299631454bd81006db33d51192cacc1404a5c9779607802
SHA512:
e7f06afc7617df7e3325bce8e34d1d78c4d130c40135661e59ae0eabef50df888759a125dae3ab9556fc940d621c695a50e674ebad8c3066716bfb5fbd27c1c4
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/joewitt.asc
KEYS file available here:
https://dist.apache.org/repos/dist/release/nifi/KEYS
39 issues were closed/resolved for this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12348757
Release note highlights can be found here:
https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.12.1
The vote will be open for 72 hours.
Please download the release candidate and evaluate the necessary items
including checking hashes, signatures, build
from source, and test. Then please vote:
[ ] +1 Release this package as nifi-1.12.1
[ ] +0 no opinion
[ ] -1 Do not release this package because...
