I have a couple of thoughts on this change. I was actually considering making the same change a few days ago.
Changing the default value should not affect existing flows. We specifically persist all property values, including default values, specifically so that we can change the default value of a property without affecting existing flows. We have definitely changed default values before. That said, it’s always considered on a case-by-case basis because with very old versions, we did not persist default values. So if a user upgrades from a very old version (perhaps 1.2?) then it would change the value. But as I said, we have change default values In the past, so other things would also be changed. I think I would be in favor of changing the default. Perhaps it would be helpful to add a note to the Migration Guidance though? Thanks -Mark > On Dec 6, 2020, at 9:33 AM, Joe Witt <[email protected]> wrote: > > This change makes sense as what we should have started with but would have > very different behavior for existing flows. Right? If so we really > cannot do this like this. We will need to think of another way that doesnt > break existing flows but still raises awareness for new users. > > On Sun, Dec 6, 2020 at 6:41 AM Mike Thomsen <[email protected]> wrote: > >> I put up a PR for it here: https://github.com/apache/nifi/pull/4711 >> >> I think in the last month or so I've seen three different people have >> this same issue where they didn't even know that line by line >> evaluation was possible and blew up NiFi by evaluating very large >> files in memory. >> >> Looked like a really straight forward change. >> >> Thoughts? >>
