-1: there is a difference between released source and the git tag
minifi-cpp-0.9.0-RC1
I attached diff while comparing the two recursively, output of "diff
-r". Also discussed with Marton Szasz.
On the positive side:
Built and tested on Ubuntu 18.04.
Verified checksums and signatures.
Connected to EFM and updated with simple workflow:
GetFile >> PutFile
Regards,
Ádám
On Wed, Feb 17, 2021 at 8:03 PM Marc Parisi <[email protected]> wrote:
>
> +1
>
> Verified sigs and hashes
>
> Built on PopOS ( based-off of U20.04 ). I haven't tried this release on my
> ARM platforms, but will try as soon as I can.
> Ran basic flow pulling log data (TailFile) and sending to an Apache NiFi
> node via SiteToSite.
>
> I think the work done in 0.9.0 has been great and applaud those that have
> put work into it.
>
> I will try to take a look at the JNI package. If an issue was created feel
> free to ping me on it.
>
>
> Thanks,
> Marc
>
> On Wed, Feb 17, 2021 at 5:38 AM Pierre Villard <[email protected]>
> wrote:
>
> > +1 binding
> >
> > Verified checksums and signature.
> > Built on Ubuntu 20.04.
> > Tested GenerateFlowFile -> MergeContent -> InvokeHTTP
> >
> > Thanks,
> > Pierre
> >
> > Le mer. 17 févr. 2021 à 14:24, Gábor Gyimesi <[email protected]> a
> > écrit :
> >
> > > +1 (non-binding)
> > >
> > > Verified checksums and signature.
> > > Built on Ubuntu 20.04 with Kafka, Coap, SFTP and AWS extensions.
> > > Executed tests.
> > > Tested a simple flow with C2 server.
> > >
> > > BR,
> > > Gabor
> > >
> > > On Tue, 16 Feb 2021 at 23:54, Arpad Boda <[email protected]> wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > Verified hashes and signature.
> > > > Built and executed tests both on Debian 10 and Win 10.
> > > > Started agent, connected to C2 server, designed simple flow.
> > > >
> > > > Cheers,
> > > > Arpad
> > > >
> > > > On Tue, Feb 16, 2021 at 4:57 PM Ferenc Gerlits
> > > > <[email protected]> wrote:
> > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > Verified hashes and the signature on the source bundle. Suggestion:
> > > the
> > > > > format of the hash file could be changed to "<hash> *<file name>" so
> > > one
> > > > > can run eg. 'sha256 -c ...'.
> > > > > Built on (a Docker container running) Ubuntu 20.04, enabling
> > everything
> > > > > except
> > > > > * TensorFlow, because I could not find an Ubuntu package for
> > > > libtensorflow;
> > > > > * and JNI -- this built without error, but then I had to disable it
> > > > because
> > > > > it caused a runtime error at startup. I don't think this is a
> > > > showstopper.
> > > > > Ran the binary using a simple InvokeHTTP -> LogAttribute flow yaml
> > > > config;
> > > > > it worked as expected.
> > > > >
> > > > > Thanks,
> > > > > Ferenc
> > > > >
> > > > > On Tue, Feb 16, 2021 at 4:23 PM Adam Debreceni <
> > [email protected]>
> > > > > wrote:
> > > > >
> > > > > > +1 (non-binding)
> > > > > >
> > > > > > Verified checksums and signatures.
> > > > > > Built on Windows 10 with kafka. Can connect to c2 server and
> > receive
> > > > > > updates.
> > > > > > Can process windows event logs in various JSON formats and send
> > them
> > > to
> > > > > > kafka
> > > > > > through SSL, in a multi broker setup.
> > > > > >
> > > > > > On Tue, Feb 16, 2021 at 9:50 AM Marton Szasz <[email protected]>
> > > > wrote:
> > > > > >
> > > > > > > Hello,
> > > > > > >
> > > > > > > I am pleased to be calling this vote for the source release of
> > > Apache
> > > > > > > NiFi MiNiFi C++ 0.9.0
> > > > > > >
> > > > > > > The source tarball, including signatures, digests, etc. can be
> > > found
> > > > > at:
> > > > > > >
> > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/0.9.0/
> > > > > > >
> > > > > > > The Git tag is minifi-cpp-0.9.0
> > > > > > > The Git commit ID is a52faa5136031abfcc321a44fbcd954ee0f73764
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;a=commit;h=a52faa5136031abfcc321a44fbcd954ee0f73764
> > > > > > >
> > > > > > > Checksums of nifi-minifi-cpp-0.9.0-source.tar.gz:
> > > > > > > SHA256:
> > > > > 40fa837c86707e3bf0e8f0aca5bc279d81320aaaa5cd326edf809e7785af7282
> > > > > > > SHA512:
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > 43490ba823d7846c3cc323a634d756a0a33828f5c82a623d19b77c4ddfe3248aa524245ee2c47a7fd04f41c3611758972307e221fa0a254e0aa5831c4f9b03f2
> > > > > > >
> > > > > > > Release artifacts are signed with the following key:
> > > > > > > https://people.apache.org/keys/committer/szaszm.asc
> > > > > > >
> > > > > > > KEYS file available here:
> > > > > > > https://dist.apache.org/repos/dist/release/nifi/KEYS
> > > > > > >
> > > > > > > 200 issues were closed/resolved for this release:
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321520&version=12345444
> > > > > > >
> > > > > > > Release note highlights can be found here:
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/MINIFI/Release+Notes#ReleaseNotes-Versioncpp-0.9.0
> > > > > > >
> > > > > > > The vote will be open for 72 hours.
> > > > > > > Please download the release candidate and evaluate the necessary
> > > > items
> > > > > > > including checking hashes, signatures, build from source, and
> > test.
> > > > > > > Then please vote:
> > > > > > >
> > > > > > > [ ] +1 Release this package as nifi-minifi-cpp-0.9.0
> > > > > > > [ ] +0 no opinion
> > > > > > > [ ] -1 Do not release this package because...
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
Only in .: bt_state
diff -r ./cmake/DockerConfig.cmake /home/adam/work/nifi-minifi-cpp/cmake/DockerConfig.cmake
57a58
> -c BUILD_NUMBER=${BUILD_NUMBER}
68a70
> -c BUILD_NUMBER=${BUILD_NUMBER}
diff -r ./docker/test/integration/minifi/core/DockerTestCluster.py /home/adam/work/nifi-minifi-cpp/docker/test/integration/minifi/core/DockerTestCluster.py
17a18,19
> from .utils import retry_check
>
184a187
> @retry_check()
189a193
> @retry_check()
195a200
> @retry_check()
216c221
<
---
>
Only in /home/adam/work/nifi-minifi-cpp/docker/test/integration/minifi/core: utils.py
Only in ./extensions/standard-processors/tests: .device_id
diff -r ./extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp /home/adam/work/nifi-minifi-cpp/extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp
712c712
< "property 'Prop B' is exclusive of property 'Prop A' values matching '^val.*$' "
---
> "property 'Prop B' must not be set when the value of property 'Prop A' matches '^val.*$' "
Only in /home/adam/work/nifi-minifi-cpp/: .git
Only in ./libminifi/src/agent: agent_version.cpp
diff -r ./libminifi/src/core/yaml/YamlConfiguration.cpp /home/adam/work/nifi-minifi-cpp/libminifi/src/core/yaml/YamlConfiguration.cpp
898,900c898,899
< std::stringstream reason;
< reason << "required property '" << prop_pair.second.getName() << "' is not set";
< raiseComponentError(component_name, yaml_section, reason.str());
---
> std::string reason = utils::StringUtils::join_pack("required property '", prop_pair.second.getName(), "' is not set");
> raiseComponentError(component_name, yaml_section, reason);
902,904c901,902
< std::stringstream reason;
< reason << "Property '" << prop_pair.second.getName() << "' is not valid";
< raiseComponentError(component_name, yaml_section, reason.str());
---
> std::string reason = utils::StringUtils::join_pack("the value '", prop_pair.first, "' is not valid for property '", prop_pair.second.getName(), "'");
> raiseComponentError(component_name, yaml_section, reason);
919,923c917,918
< std::string reason("property '");
< reason.append(prop_pair.second.getName());
< reason.append("' depends on property '");
< reason.append(dep_prop_key);
< reason.append("' which is not set");
---
> std::string reason = utils::StringUtils::join_pack("property '", prop_pair.second.getName(),
> "' depends on property '", dep_prop_key, "' which is not set");
941,947c936,937
< std::string reason("property '");
< reason.append(prop_pair.second.getName());
< reason.append("' is exclusive of property '");
< reason.append(excl_pair.first);
< reason.append("' values matching '");
< reason.append(excl_pair.second);
< reason.append("'");
---
> std::string reason = utils::StringUtils::join_pack("property '", prop_pair.second.getName(),
> "' must not be set when the value of property '", excl_pair.first, "' matches '", excl_pair.second, "'");
960,962c950,951
< std::stringstream reason;
< reason << "property '" << prop_pair.second.getName() << "' does not match validation pattern '" << prop_regex_str << "'";
< raiseComponentError(component_name, yaml_section, reason.str());
---
> std::string reason = utils::StringUtils::join_pack("property '", prop_pair.second.getName(), "' does not match validation pattern '", prop_regex_str, "'");
> raiseComponentError(component_name, yaml_section, reason);
Only in ./libminifi/test: persistencetest_flowfile_checkpoint
Only in ./libminifi/test: repotest_flowfile_checkpoint
