Tim,

   The original author resubmitted the PR here:
https://github.com/apache/nifi/pull/5326

Thanks for the bump,
Mike

On Fri, Aug 20, 2021 at 3:19 PM Smith, Tim <[email protected]> wrote:

> Mark,
>
>
>    Will do. Since repository is gone, I'll pull in the code and resubmit a
> PR.
>
>
> Thanks,
>
>
> Tim
>
>
> ________________________________
> From: Mark Payne <[email protected]>
> Sent: Friday, August 20, 2021 9:34 AM
> To: [email protected]
> Subject: Re: Pull request for ValidateJSON revisit
>
> Tim,
>
> It looks like I’d done a review but then there were updates and I missed
> the fact that the PR had been updated.
>
> My main concern was with the licensing. It looks like I thought it was MIT
> but in fact it was ASL v2 (either I looked at the wrong dependency or the
> license was changed).
> Looking through its LICENSE and NOTICE file, it doesn’t appear that there
> is anything needed in the license.
>
> At this point, it looks like the PR has been closed, and I cannot re-open
> it (Says “The repository that submitted this pull request has been
> deleted.”). Based on a quick re-review, I think the PR is okay otherwise.
> If you want to open another PR I should be able to quickly review & merge.
>
> Thanks
> -Mark
>
>
> [1]
>
> > On Aug 20, 2021, at 7:23 AM, Smith, Tim <[email protected]> wrote:
> >
> > The pull request for a ValidateJSON processor, NIFI-7392:
> >
> > https://github.com/apache/nifi/pull/4232  for
> >
> > has been marked as stale. From the review comments, this request was
> near approval. There was an outstanding question on licensing that still
> may exist. I have a similar need for this capability. Could this pull
> request be revisited? I would rather not duplicate effort.
> >
> >
> > Tim
>
>

Reply via email to