Should the ticket include in addition to the removal of the duplicate dependencies the enforcement rules or just focus on the removal of the duplicate dependencies?
On Thu, Sep 29, 2022 at 5:56 PM David Handermann < exceptionfact...@apache.org> wrote: > Dan, > > Thanks for the text reference and clarification. With those details, yes, > it looks like the duplicates should be removed from the modules listed. > Feel free to create a Jira issue to address this, and we should also > consider implementing some enforcement to avoid future duplicates. > > Regards, > David Handermann > > On Thu, Sep 29, 2022 at 4:21 PM Dan S <dsti...@gmail.com> wrote: > > > Sorry about that. I did not realize I could not include an image. Here > is a > > text version: > > > > Warning:(624, 10) Dependency is duplicated in file(s): > > nifi-zendesk-processors > > Warning:(629, 10) Dependency is duplicated in file(s): > > nifi-zendesk-processors > > Warning:(644, 10) Dependency is duplicated in file(s): > > minifi-c2-provider-cache, minifi-c2-provider-delegating, > > minifi-c2-provider-nifi-rest, minifi-c2-provider-util, > > nifi-azure-reporting-task, nifi-pgp-processors, nifi-pgp-service, > > nifi-registry-framework, nifi-registry-jetty, > > nifi-registry-revision-spring-jdbc, nifi-registry-aws-extensions, > > nifi-registry-ranger-plugin, and nifi-registry-toolkit-persistence > > Warning:(654, 10) Dependency is duplicated in file(s): > > nifi-system-test-suite > > Warning:(659, 10) Dependency is duplicated in file(s): > > nifi-registry-framework, nifi-registry-jetty, nifi-registry-properties, > > nifi-registry-security-utils, and nifi-registry-web-api > > > > On Thu, Sep 29, 2022 at 5:16 PM David Handermann < > > exceptionfact...@apache.org> wrote: > > > > > Dan, > > > > > > Thanks for asking about these dependencies. The attached image did not > > come > > > through to the list, but the XML snippet shows the standard test > > > dependencies. These dependencies are applied to all modules by design, > to > > > avoid unnecessary repetition in child modules. > > > > > > Regards, > > > David Handermann > > > > > > On Thu, Sep 29, 2022 at 4:06 PM Dan S <dsti...@gmail.com> wrote: > > > > > > > When looking in the top level pom.xml in IntelliJ I see > > > > > > > > [image: image.png] > > > > > > > > > > > > The duplicate dependencies are: > > > > <dependency> > > > > <groupId>org.junit.jupiter</groupId> > > > > <artifactId>junit-jupiter-api</artifactId> > > > > <scope>test</scope> > > > > </dependency> > > > > <dependency> > > > > <groupId>org.junit.jupiter</groupId> > > > > <artifactId>junit-jupiter-engine</artifactId> > > > > <scope>test</scope> > > > > </dependency> > > > > <dependency> > > > > <groupId>org.mockito</groupId> > > > > <artifactId>mockito-core</artifactId> > > > > <scope>test</scope> > > > > </dependency> > > > > <dependency> > > > > <groupId>org.slf4j</groupId> > > > > <artifactId>slf4j-simple</artifactId> > > > > <scope>test</scope> > > > > </dependency> > > > > <dependency> > > > > <groupId>org.codehaus.groovy</groupId> > > > > <artifactId>groovy-test</artifactId> > > > > <scope>test</scope> > > > > </dependency> > > > > > > > > I assume these are oversites. Is this something a ticket should be > made > > > > for to fix? > > > > > > > > > > > > > > > > > > > > > >
