+1 (non-binding)

I’ve found two minor issues. I believe none of them is a blocker, but we should 
follow up on them. Marked them with ***.

Went through the release helper guide on:
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Java version: 1.8.0_332, vendor: Temurin
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"

Imported flows from NiFi registry for these issues and verified them:
- NIFI-10760 - Add Api key authentication option to 
ElasticSearchClientServiceImpl
    - *** A validation has been removed, which prevented using Basic and Api 
Key properties together.
             If I set Username/Password and hide them by selecting Api Key 
Authorization Scheme, the client will still use those credentials. If I set Api 
Key, the client will add both credentials as a request header.
             Opened NIFI-10880 for further discussion.
- NIFI-10668 - Persist proxy password in remote process group
- NIFI-10656 - Log ignored event with info instead of warning in PutADLS
- NIFI-10650 - Fix demarcator is appended to the end of the FlowFile's content 
by ConsumeMQTT
- NIFI-10644 - Add Message Demarcator-style processing in PublishMQTT
- NIFI-10543 - Support broker failover in MQTT processors
- NIFI-10491 - PutAzureBlobStorage_v12 should have Conflict Resolution Strategy
- NIFI-10317 - NullPointerException if AMQP header value is null

*** Initially, I wanted to build NiFi in a docker container but experienced 
intermittent test failures. Most of the time, an 5 sec Test timeout caused 
issues in TestStandardFlowFileQueue.
      I don’t know why such a timeout was used, but I opened NIFI-10881 for 
further discussion.

Thanks for RM'ing Joe!
Regards,
Soma

> On Nov 23, 2022, at 4:58 PM, Joe Witt <joew...@apache.org> wrote:
> 
> Hello,
> 
> I am pleased to be calling this vote for the source release of Apache NiFi
> 1.19.0.
> 
> The source zip, including signatures, digests, etc. can be found at:
> https://repository.apache.org/content/repositories/orgapachenifi-1216
> 
> The source being voted upon and the convenience binaries can be found at:
> https://dist.apache.org/repos/dist/dev/nifi/nifi-1.19.0/
> 
> A helpful reminder on how the release candidate verification process works:
> https://cwiki.apache.org/confluence/display/NIFI/How+to+help+verify+an+Apache+NiFi+release+candidate
> 
> The Git tag is nifi-1.19.0-RC1
> The Git commit ID is ec87bf93add2f645d2ea426002e0c24db54614ff
> https://gitbox.apache.org/repos/asf?p=nifi.git;a=commit;h=ec87bf93add2f645d2ea426002e0c24db54614ff
> 
> Checksums of nifi-1.19.0-source-release.zip:
> SHA256: 909c4fce81b305af955540f83115474d139c132e886847df7b76e94efd3d4641
> SHA512:
> b3ba95984841140aa2a9a2ea471dd446d6fbd71dba320f723839e0938a7873f847e415a88b7c38e59907ad051c896949f0c7093c6d5e6b5db549de929ec32c6e
> 
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/joewitt.asc
> 
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/nifi/KEYS
> 
> 221 issues were closed/resolved for this release:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12352150
> 
> Release note highlights can be found here:
> https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.19.0
> 
> The vote will be open for at least 72 hours.
> Please download the release candidate and evaluate the necessary items
> including checking hashes, signatures, build
> from source, and test. Then please vote:
> 
> [ ] +1 Release this package as nifi-1.19.0
> [ ] +0 no opinion
> [ ] -1 Do not release this package because...

Reply via email to