+1 (non-binding) - Went through the helper guide, full clean build, verified signatures and hashes * Built on MacOS 13.1.6 * Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /Users/fkis/.sdkman/candidates/maven/current Java version: 11.0.7, vendor: AdoptOpenJDK, runtime: /Users/fkis/.sdkman/candidates/java/11.0.7.hs-adpt Default locale: en_GB, platform encoding: UTF-8 - Started NiFi, created a simple flow with ListenHTTP - Started MiNiFi Java: * tested flow received and started via C2 protocol * NIFI-10895: validated property update works via C2 protocol
Thanks Joe for RMing! Regards Ferenc On Thu, Feb 9, 2023 at 5:53 PM Csaba Bejan <bejan.cs...@gmail.com> wrote: > +1 (non-binding) > > - Went through the helper guide and did a clean build > - Verified signatures and hashes > - Built on OSX 11.6.6 > - AdoptOpenJDK (build 1.8.0_282-b08) > - Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) > > - Started NiFi and created a simple flow > - NIFI-10895: > Verified that MiNiFi starts up and properties can be updated (and changes > are applied after automatic restart) via C2 protocol (UPDATE/PROPERTIES) > Verified that FileChangeIngestor configuration is not needed anymore, > bootstrap notifies the service directly about the flow update > > Thanks for RM’ing, Joe! > > Csaba > > > On 2023. Feb 9., at 14:21, Krisztina Zsihovszki <zsikr...@gmail.com> > wrote: > > > > +1 (non-binding) > > > > - Verified signatures and hashes > > - Ran build using Maven 3.8.7 > > - Ran build on macOS 12.6.3 with AdoptOpenJDK build 1.8.0_275-b01, unit > > tests passed > > - Ran build on macOS 12.6.3 with AdoptOpenJDK build 11.0.2+9, unit tests > > passed > > > > Verified the following tickets: > > > > [NIFI-10618] - Add GetAsanaObject Processor > > [NIFI-11087] - Add Processor to Verify Content using HMAC algorithm > > [NIFI-10832] - Create PutSalesforceObject processor - found minor issues, > > created a follow-up ticket (NIFI-11158) to address them > > [NIFI-10965] - Add PutGoogleDrive processor (covered checking NIFI-11068 > > and NIFI-11117 as well) > > > > Thanks for RM’ing, Joe! > > > > Regards, > > Krisztina > > > > On Thu, Feb 9, 2023 at 2:26 AM Jeremy Dyer <jdy...@gmail.com> wrote: > > > >> +1 (binding) > >> > >> Signatures and hashes look good, build and tests work fine on ubuntu 22 > >> system. Setup and ran some basic flows all of which worked as expected. > >> Looks good to me. > >> > >> Thanks for getting the release together Joe > >> > >> - Jeremy Dyer > >> > >> On Wed, Feb 8, 2023 at 7:18 PM Kevin Doran <kdo...@apache.org> wrote: > >> > >>> +1 (binding) > >>> > >>> Ran through the normal verification steps / checked signatures and > >> hashes. > >>> All looks good. > >>> > >>> Thanks for RM’ing, Joe! > >>> > >>> Kevin > >>> > >>> On Feb 8, 2023 at 14:33:31, Nissim Shiman <nshi...@yahoo.com.invalid> > >>> wrote: > >>> > >>>> +1 (non-binding) > >>>> > >>>> verified source release sha256/512 checksums > >>>> > >>>> > >>>> built and ran successfully using:Apache Maven 3.6.3 Java openjdk > >> version: > >>>> 1.8.0_352 > >>>> linux kernel 3.10.0-1160 > >>>> > >>>> > >>>> Verified various simple flows. > >>>> > >>>> Noticed issue where content viewer doesn't handle very large files > >> (i.e. > >>>> 100MB) well. nifi screen looses look and feel when this occurs and > >>>> displays OutOfMemoryError > >>>> > >>>> Put in a jira for this > >> https://issues.apache.org/jira/browse/NIFI-11153 > >>>> > >>>> This would be a very limited user initiated edge case, so I don't > think > >>>> this is a blocker. > >>>> > >>>> > >>>> Thank you for the upcoming release! > >>>> > >>>> Nissim Shiman > >>>> > >>>> > >>>> On Monday, February 6, 2023 at 08:56:10 PM UTC, Joe Witt < > >>>> joew...@apache.org> wrote: > >>>> > >>>> Hello, > >>>> > >>>> I am pleased to be calling this vote for the source release of Apache > >>> NiFi > >>>> 1.20.0. > >>>> > >>>> The source zip, including signatures, digests, etc. can be found at: > >>>> https://repository.apache.org/content/repositories/orgapachenifi-1220 > >>>> > >>>> The source being voted upon and the convenience binaries can be found > >> at: > >>>> https://dist.apache.org/repos/dist/dev/nifi/nifi-1.20.0/ > >>>> > >>>> A helpful reminder on how the release candidate verification process > >>> works: > >>>> > >>>> > >>> > >> > https://cwiki.apache.org/confluence/display/NIFI/How+to+help+verify+an+Apache+NiFi+release+candidate > >>>> > >>>> The Git tag is nifi-1.20.0-RC1 > >>>> The Git commit ID is 81296b5b69a69d26afb8f8dec3a58a8363653890 > >>>> > >>>> > >>> > >> > https://gitbox.apache.org/repos/asf?p=nifi.git;a=commit;h=81296b5b69a69d26afb8f8dec3a58a8363653890 > >>>> > >>>> Checksums of nifi-1.20.0-source-release.zip: > >>>> SHA256: > >> 694e9eec951caf628576a2aaa16e7ddadc11b9bf455f16d503bdd88aefdbfe66 > >>>> SHA512: > >>>> > >>>> > >>> > >> > f54891aadbf58eaf4df465e99eb935ddbb47c70c1e329968098762f670eeed56a427ed88f21f150c056f8b057f7120127f3470afe4f4f89b80d659d7b8080339 > >>>> > >>>> Release artifacts are signed with the following key: > >>>> https://people.apache.org/keys/committer/joewitt.asc > >>>> > >>>> KEYS file available here: > >>>> https://dist.apache.org/repos/dist/release/nifi/KEYS > >>>> > >>>> 205 issues were closed/resolved for this release: > >>>> > >>>> > >>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12352581 > >>>> > >>>> Release note highlights can be found here: > >>>> > >>>> > >>> > >> > https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.20.0 > >>>> > >>>> The vote will be open for 72 hours. > >>>> Please download the release candidate and evaluate the necessary items > >>>> including checking hashes, signatures, build > >>>> from source, and test. Then please vote: > >>>> > >>>> [ ] +1 Release this package as nifi-1.20.0 > >>>> [ ] +0 no opinion > >>>> [ ] -1 Do not release this package because... > >>>> > >>>> > >>> > >> > >