Drew, Thanks for finding this problem, and thanks Chris for the confirmation.
I was able to reproduce the problem and filed NIFI-12392 [1] for tracking. I also submitted GitHub PR 8052 [2] to resolve the issue, which can be applied to both the main and support branches. The pull request introduces additional unit tests for the NarUnpacker, which was the source of the problem as a result of recent changes for NIFI-12294 [3]. Regards, David Handermann [1] https://issues.apache.org/jira/browse/NIFI-12392 [2] https://github.com/apache/nifi/pull/8052 [3] https://issues.apache.org/jira/browse/NIFI-12294 On Sun, Nov 19, 2023 at 2:35 AM Chris Sampson <chris.samp...@naimuri.com.invalid> wrote: > > Drew, > > Good spot. I’ve removed my local install of 1.24.0 RC now in favour of > 2.0.0-M1 RC release testing, but can confirm that the same problem exists > there and it’s not limited to the Elasticsearch components, e.g. UpdateRecord > is also missing the additionalDetails link. So it looks like there’s a > general documentation issue that has crept in to both release branches. > > This is probably enough to warrant further investigation and inclusion in the > releases through another set of RC votes. > > I wonder whether there’s a set of tests that could be added (maybe to the > assembly builds) that extract the constructed binaries and check for > LICE/NOTICE files along with additionalDetails.html files being present > (probably a separate ticket to fixing the immediate documentation issue)? > > > Cheers, > > --- > Chris Sampson > > > > On 19 Nov 2023, at 04:07, Andrew Lim <andrewlim.apa...@gmail.com> wrote: > > > > This might just be user error on my part, but I don’t see the “Additional > > Details” link for processors, controller services, etc. in the embedded > > documentation. > > > > I successfully ran a full clean install on macOS (Ventura 13.0.1, OpenJDK > > version 1.8.0_372). I wanted to verify the Documentation changes in 1.24.0 > > and started with https://issues.apache.org/jira/browse/NIFI-12322. > > > > But I don’t see the “Additional Details” link in the 1.24.0 embedded doc > > for this controller service, like I do here in 1.23.0: > > > > https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-elasticsearch-client-service-nar/1.23.2/org.apache.nifi.elasticsearch.ElasticSearchClientServiceImpl/index.html > > > > I confirmed that in the path > > nifi-1.24.0/work/docs/components/org.apache.nifi/nifi-elasticsearch-client-service-nar/1.24.0 > > the additionalDetails.html file doesn’t exist. > > > > Is anyone else seeing the same thing? > > > > Thanks, > > Drew > > > > > > > >> On Nov 16, 2023, at 2:00 PM, Pierre Villard <pierre.villard...@gmail.com> > >> wrote: > >> > >> Team, > >> > >> I am pleased to be calling this vote for the source release of Apache NiFi > >> 1.24.0. > >> > >> Please review the following guide for how to verify a release candidate > >> build: > >> > >> https://cwiki.apache.org/confluence/display/NIFI/Release+Candidate+Verification > >> > >> The source being voted on the and the convenience binaries are available on > >> the Apache Distribution Repository: > >> > >> https://dist.apache.org/repos/dist/dev/nifi/nifi-1.24.0 > >> > >> The build artifacts are available on the Apache Nexus Repository: > >> > >> https://repository.apache.org/content/repositories/orgapachenifi-1241 > >> > >> Git Tag: nifi-1.24.0-RC3 > >> Git Commit ID: 586a1a8789e9c39914f4a6088ac26e22d60eeb91 > >> GitHub Commit Link: > >> https://github.com/apache/nifi/commit/586a1a8789e9c39914f4a6088ac26e22d60eeb91 > >> > >> Checksums of nifi-1.24.0-source-release.zip > >> > >> SHA256: 590cf9b1219f9fd66c81cc1740b2e245d85e341cdc280c769d354084dc27ee8a > >> SHA512: > >> 8d3b9cb9c4686242620ad40ad83fadb972403ee70a101cbb6fa0116b54ad7793702da230871281c0de40322ddfdbfc89dacba7b690465e7b2329850dca5132e8 > >> > >> Release artifacts are signed with the following key: > >> > >> https://people.apache.org/keys/committer/pvillard.asc > >> > >> KEYS file is available on the Apache Distribution Repository: > >> > >> https://dist.apache.org/repos/dist/release/nifi/KEYS > >> > >> Issues resolved for this version: 280 > >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12353443 > >> > >> Release note highlights can be found on the project wiki: > >> > >> https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.24.0 > >> > >> The vote will be open for 72 hours. > >> > >> Please download the release candidate and evaluate the necessary items > >> including checking hashes, signatures, build from source, and test. Then > >> please vote: > >> > >> [] +1 Release this package as nifi-1.24.0 > >> [] +0 no opinion > >> [] -1 Do not release this package because... > > >
