+1 (binding) Went through the usual steps. Everything LGTM. Very excited by this first milestone for NiFi 2.0!
Thanks David for RM'ing! Le ven. 24 nov. 2023 à 17:37, Csaba Bejan <[email protected]> a écrit : > +1 (binding) > > - Went through the helper guide and did a clean build > - Verified signatures and hashes > - Built on OSX 14.1.1 > - Java version: Zulu21.28+85-CA (build 21+35) > - Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) > > - Started NiFi and created a simple flow > - Started MiNiFi and verified integration with C2 Server. Played around > with the C2 protocol (Operations - Update, Transfer, Describe...) > > Verified: > - NIFI-11514 MiNiFi Flow JSON support and deprecating YAML format. > Migration tool from YAML to JSON > - NIFI-12333 MiNiFi property override through env and system variables > - NIFI-12335 Fix MiNiFi startup issue > > Thanks for RMing, David! > > Regards, > Csaba > > > On 24 Nov 2023, at 15:12, Márk Báthori <[email protected]> wrote: > > > > +1 (non-binding) > > > > Built on: > > - OSX 13.4 > > - Java version: Azul Zulu version 1.8.0_332 > > - Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > > > > - Went through the helper guide and did a full clean build with contrib > > check > > - Verified signatures and hashes > > > > Tested various simple flows successfully. > > > > Verified the following tickets: > > - [NIFI-9206] - Create a processor that is capable of removing fields > from > > records > > - [NIFI-12130] - PutIceberg: Ability to configure snapshot properties via > > dynamic attributes > > - [NIFI-11263] - Add case-insensitive and order independent field mapping > > to PutIceberg record converter > > - [NIFI-12088] - UI - Dependent Properties are not shown when depending > on > > newly created Service > > - [NIFI-11342] - HDFS processors fail to get ClassloaderIsolationKey at > > startup > > - [NIFI-11177] - PutIceberg cannot write null Timestamp into Iceberg > table > > - [NIFI-11215] - Add custom validation for KerberosUserService in > PutIceberg > > > > Thank you for RMing David! > > > > Regards, > > Mark > > > > Ferenc Kis <[email protected]> ezt írta (időpont: 2023. nov. 24., > P, > > 11:31): > > > >> +1 (non-binding) > >> > >> Went through the helper guide, local maven repo cleaned up, full clean > >> build with contrib check, verified signatures and hashes > >> > >> Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) > >> Maven home: /Users/fkis/.sdkman/candidates/maven/current > >> Java version: 21, vendor: Azul Systems, Inc., runtime: > >> /Users/fkis/.sdkman/candidates/java/21-zulu/zulu-21.jdk/Contents/Home > >> Default locale: en_HU, platform encoding: UTF-8 > >> OS name: "mac os x", version: "13.4.1", arch: "aarch64", family: "mac" > >> > >> Validations performed: > >> - Started NiFi, created a simple flow with ListenHTTP and Input Port. > >> Validated ListenHTTP processor is able to receive data > >> - Started MiNiFi Java: > >> * created a simple GenerateFlowFile -> InvokeHttp flow and > >> GenerateFlowFile -> RemoteProcessGroup flow and pushed to MiNiFi via C2 > >> protocol. Validated that connectivity between NiFi and MiNiFi works via > >> both InvokeHTTP and S2S > >> > >> Thanks for RMing David! > >> > >> Regards > >> Ferenc > >> > >> On Fri, Nov 24, 2023 at 1:05 AM Dan S <[email protected]> wrote: > >> > >>> +1 (non-binding) > >>> > >>> - Verified binary hashes and signatures > >>> - Successfully built NiFi with contrib-check using: > >>> - Apache Maven 3.9.5 > >>> - Java 21 Oracle Corporation > >>> - Centos 7 Linux 3.10.0-1160.90.1.el7.x86_64 > >>> > >>> Exercised the following bug fixes and features > >>> NIFI-2964 Confirmed the ability to allow attributes already JSON to > >> remain > >>> JSON and not be escaped when the Nested strategy is chosen. Created > >>> NIFI-12408 <https://issues.apache.org/jira/browse/NIFI-12408> to > improve > >>> AttributesToJson with an option to pretty print the resulting JSON when > >> the > >>> destination is flowfile content. > >>> NIFI-11156 Ensured the 'validatexml.invalid.error' contains an error > >>> message whether an XSD is specified or not. > >>> NIFI-11959 Confirmed Single comment allowed. > >>> NIFI-12165 Confirmed "Custom Transformation Class Name" and "Custom > >> Module > >>> Directory" no longer vanish when configuring JoltTransformJSON and > >>> JoltTransformRecord. > >>> NIFI-11167 Exercised Excel Record Reader by running sample Excel files > >>> converting them to CSV. > >>> NIFI-11197 Exercised Yaml Record Reader Ran by running sample Yaml > files > >>> converting them to JSON and in the process discovered that Yaml aliases > >> are > >>> not resolved. Created NIFI-12404 > >>> <https://issues.apache.org/jira/browse/NIFI-12404> to at least > document > >>> that YamlTreeReader does not support resolving Yaml aliases. > >>> NIFI-11509 Confirmed source JSON can have comments. > >>> NIFI-12100 Confirmed removal of ConvertExcelToCSVProcessor and that it > no > >>> longer is in the documentation. > >>> NIFI-12392 Confirmed those processors used by above tickets which have > >>> additional details are actually seen. > >>> > >>> Thanks David for Rming and for creating so many RCs to get this version > >>> right! > >>> > >>> On Thu, Nov 23, 2023 at 12:05 PM Joe Witt <[email protected]> wrote: > >>> > >>>> +1 binding > >>>> > >>>> Checked all the things. Fired it up. Looks great. > >>>> > >>>> Huge thanks to you David for continuing through this challenging > >> release > >>> as > >>>> an RM. And also to all who keep participating in this vote. NiFi 2.0 > >> is > >>>> super important to the future of NiFi and this milestone release is a > >>> great > >>>> step forward. > >>>> > >>>> Thanks > >>>> > >>>> On Thu, Nov 23, 2023 at 2:21 AM Gábor Gyimesi <[email protected]> > >>> wrote: > >>>> > >>>>> +1 (non-binding) > >>>>> > >>>>> Went through the same verification process as per the previous RC, > >>> LGTM: > >>>>> > >>>>> - Verified binary hashes and signatures > >>>>> - Successfully built NiFi with contrib-check using: > >>>>> - Apache Maven 3.6.3 > >>>>> - Java 21 2023-09-19 LTS > >>>>> - Ubuntu 22.04 6.2.0-36-generic > >>>>> - Designed and ran some simple flows successfully > >>>>> - Tested minifi-c2 server successfully with MiNiFi C++ (using a draft > >>> of > >>>>> the change conforming the new header requirements > >>>>> https://issues.apache.org/jira/browse/MINIFICPP-2244) > >>>>> - Built and started docker container successfully from > >>>>> nifi-docker/dockerhub/Dockerfile > >>>>> > >>>>> Thanks David! > >>>>> > >>>>> Best Regards, > >>>>> Gabor > >>>>> > >>>>> On Thu, 23 Nov 2023 at 03:49, David Handermann < > >>>>> [email protected]> > >>>>> wrote: > >>>>> > >>>>>> Team, > >>>>>> > >>>>>> Thank you for your patience and continued support in reviewing > >> these > >>>>>> release candidates. > >>>>>> > >>>>>> I am pleased to be calling this vote for the source release of > >> Apache > >>>>>> NiFi 2.0.0-M1. > >>>>>> > >>>>>> Please review the following guide for how to verify a release > >>> candidate > >>>>>> build: > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://cwiki.apache.org/confluence/display/NIFI/Release+Candidate+Verification > >>>>>> > >>>>>> The source being voted on the and the convenience binaries are > >>>>>> available on the Apache Distribution Repository: > >>>>>> > >>>>>> https://dist.apache.org/repos/dist/dev/nifi/nifi-2.0.0-M1 > >>>>>> > >>>>>> The build artifacts are available on the Apache Nexus Repository: > >>>>>> > >>>>>> > >>> https://repository.apache.org/content/repositories/orgapachenifi-1250 > >>>>>> > >>>>>> Git Tag: nifi-2.0.0-M1-RC6 > >>>>>> Git Commit ID: 49fa0d86746f544e294b4ba04b2795d426ba0271 > >>>>>> GitHub Commit Link: > >>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://github.com/apache/nifi/commit/49fa0d86746f544e294b4ba04b2795d426ba0271 > >>>>>> > >>>>>> Checksums of nifi-2.0.0-M1-source-release.zip > >>>>>> > >>>>>> SHA256: > >>>> 1a0271c35f585a8e49c5e578422a8e3910fbfc50069a7c875bc6cec5a056eb91 > >>>>>> SHA512: > >>>>>> > >>>>> > >>>> > >>> > >> > 99e824a0bce109bde84218b914487fd44ba344d5ae9d8fbed9982b41dc2ee7e57b6dd30550c17a4868d43afd900705c48ec48d5e9e63a1b4130c79858f64963c > >>>>>> > >>>>>> Release artifacts are signed with the following key: > >>>>>> > >>>>>> https://people.apache.org/keys/committer/exceptionfactory.asc > >>>>>> > >>>>>> KEYS file is available on the Apache Distribution Repository: > >>>>>> > >>>>>> https://dist.apache.org/repos/dist/release/nifi/KEYS > >>>>>> > >>>>>> Issues resolved for this version: 959 > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12339599 > >>>>>> > >>>>>> Release note highlights can be found on the project wiki: > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version2.0.0-M1 > >>>>>> > >>>>>> The vote will be open for 72 hours. > >>>>>> > >>>>>> Please download the release candidate and evaluate the necessary > >>> items > >>>>>> including checking hashes, signatures, build from source, and test. > >>>>>> Then please vote: > >>>>>> > >>>>>> [] +1 Release this package as nifi-2.0.0-M1 > >>>>>> [] +0 no opinion > >>>>>> [] -1 Do not release this package because... > >>>>>> > >>>>> > >>>> > >>> > >> > >
