Hi Joe, and anyone interested,
I initially didn't look at the code, just wanted to confirm that it
wasn't a conscious decision. Your first reply encouraged me to take a
look at the code, and it seems the change in the committer list was
probably just a side effect of dynamically fetching the nifi group
members from Apache. I agree that it's a nice change to no longer have
to update the list manually, except for this small issue.
After some digging in the Hugo docs, the change wasn't too difficult to
make, so I submitted a pull request to exclude PMC members from the
committer list: https://github.com/apache/nifi-site/pull/83
Thanks,
Marton
On 2/21/24 21:35, Joe Witt wrote:
For anyone interested in improving the logic here is where the page lives:
https://github.com/apache/nifi-site/blob/main/content/community/_index.md
It utilizes this directive/entry such as
{{< project-members project="nifi" >}}
That is powered by a short-code in hugo terms (I'm told) which can be found
here
https://github.com/apache/nifi-site/blob/main/themes/nifi/layouts/shortcodes/project-members.html
That short-code leverages information which is found in
https://github.com/apache/nifi-site/blob/main/config.toml
on lines 31 and 32.
Perhaps the solution is to improve the logic of the short-code such that it
allows a second argument such as 'exclude-project' which might look like
{{< project-members project="nifi" exclude-project="nifi-pmc">}}
Then update the short code such that if the second argument is provided we
remove names in the 'nifi' list that are also in the 'nifi-pmc' list.
Not sure what mechanisms/etc.. are available but this should give anyone
motivated good context to work with.
Thanks
On Wed, Feb 21, 2024 at 1:18 PM Joe Witt<joe.w...@gmail.com> wrote:
Marton
I wasn't sure why so I checked the source [1] and found a very nice
improvement which is the page is now dynamically generated reflecting our
actual membership/roster in ASF records. So people don't need to mess with
this anymore which is great.
It is duplicative between PMC and Committership listing and ideally we
only show the delta since being a PMC member implies committership. I'm
sure someone could improve that logic to only list the committers.
[1]
https://github.com/apache/nifi-site/blob/main/content/community/_index.md
On Wed, Feb 21, 2024 at 10:17 AM Marton Szasz<sza...@apache.org> wrote:
Hi all,
I just noticed that on the people page of the nifi website, PMC members
are also listed under committers. This seems to be a recent change,
maybe since the redesign?
Old website without name duplication:
https://web.archive.org/web/20231208050808/https://nifi.apache.org/people.html
New website with name duplication:https://nifi.apache.org/community/
Is this change intentional? If so, why? I find it a bit confusing.
Thanks,
Marton
