Hey Bob, Thanks. I would agree. Checking for bin/ vs. scripts/ directory makes a lot of sense to me. And requiring users to go in and have to change the nifi.properties for something like that feels pretty low-level. I think this is very much the right decision.
Thanks -Mark > On Mar 14, 2024, at 10:58 AM, Bob Paulin <b...@bobpaulin.com> wrote: > > Hi, > > Just wanted to make sure this got back to the list [1]. TLDR will scan > parent directory for existence of bin then Scripts rather than detecting OS. > Determined that a nifi.properties addition to allow this to be configurable > rather in the code is not worth the additional complexity at this time. > Thanks! > > - Bob > > [1] https://github.com/apache/nifi/pull/8500 > > On 3/13/2024 5:09 PM, Bob Paulin wrote: >> >> Hi, >> >> Recently I ran into an existing issue [1] running Nifi's python extensions >> on windows. It appears that windows uses Scripts instead of bin to store >> the python virtual environment executable binaries [2]. As the user >> mentions simply renaming the directory name to bin does not work. It does >> seem to work when I introduce a config to allow the virtual environment >> binary directory to be specified [3]. This allows the directory to be >> updated following installation which enables the server to start and it >> allows me to run python processors that do not have other cross operating >> system incompatibilities. This makes windows usage with the extensions >> possible so at a minimum I'd like this PR to be considered. I've also >> worked on projects that build toggles between operating systems using Java >> System properties similar to the util Nifi has [4]. Does Nifi have an >> opinion on whether this sort of OS toggling should be automatic or just >> possible by manually updating the configs. I'm happy to update my PR to add >> some automatic toggling based on OS. Thanks! >> >> - Bob Paulin >> >> >> [1] https://issues.apache.org/jira/browse/NIFI-12514 >> >> [2] https://docs.python.org/3/library/venv.html >> >> [3] https://github.com/apache/nifi/pull/8500 >> >> [4] >> https://github.com/apache/nifi/blob/7db1664a7e2d473a5e30633bea547004e22487c6/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/OSUtil.java#L19 >>
