+1 (non-binding) Followed the helper guide and built nifi-api successfully, checked README, NOTCE, LICENCE, git hash
Java version: 21.0.3, vendor: Azul Systems, Inc., runtime: /Users/fkis/.sdkman/candidates/java/21.0.3-zulu/zulu-21.jdk/Contents/Home Default locale: en_HU, platform encoding: UTF-8 OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac" Thanks for RMing, David! Ferenc On Fri, Sep 20, 2024 at 7:38 PM Marton Szasz <sza...@apache.org> wrote: > +1 (binding) > > Followed the helper guide on NixOS unstable, with jdk22. There was a > nifi-api-2.0.0.jar generated at the end, with reasonable-looking > contents and correct LICENSE/NOTICE. > > Scripted/documented the steps and the environment in my release > verification repo: > > https://github.com/szaszm/verify-nifi-release/blob/master/verify_api_release.sh > (+ I manually reviewed the README/LICENSE/NOTICE files) > > Thanks for RMing, David! > > Marton > > On 9/20/24 19:11, Michael Moser wrote: > > +1 (binding) > > > > Followed the RC verification helper and verified the things. > > > > I noticed that TestEnvironmentVariables.java did not transition from the > > nifi repo to the nifi-api repo, but since this is a unit test, it's not > > very important. > > > > -- Mike > > > > > > > > On Fri, Sep 20, 2024 at 11:51 AM Mark Bean <mark.o.b...@gmail.com> > wrote: > > > >> +1 (non-binding) > >> > >> - Verified hash, signature and checksums > >> - Successful build on MacOS (Java 21.0.3) and Ubuntu 24.04 (Java 21.0.4) > >> > >> Slightly out of bounds of this vote, but relevant in it's own way: After > >> building main of nifi-api, not the 2.0.0 release so that I could use the > >> 2.0.0-SNAPSHOT version, removed nifi-api from nifi (main) and performed > a > >> successful build of Apache NiFi. > >> > >> Thanks David for setting up the new project and RM'ing. > >> > >> -Mark > >> > >> > >> > >> > >> On Fri, Sep 20, 2024 at 10:33 AM Gábor Gyimesi <lordga...@apache.org> > >> wrote: > >> > >>> +1 (binding) > >>> > >>> - Verified git commit, hashes, and signatures > >>> - Verified the content of LICENSE and NOTICE files > >>> - Successfully built nifi-api in the following environment: > >>> - Ubuntu 22.04 6.8.0-40-generic > >>> - java 21 2023-09-19 LTS > >>> - Apache Maven 3.9.6 > >>> > >>> Thanks David for managing the release for this! > >>> > >>> Best Regards, > >>> Gabor > >>> > >>> > >>> > >>> On Fri, 20 Sept 2024 at 15:31, Peter Turcsanyi <turcsa...@apache.org> > >>> wrote: > >>>> +1 binding > >>>> > >>>> Went through the release verification guide. > >>>> Built nifi-api on Ubuntu 24.04, Java 21 (Zulu 21.0.4+7-LTS) and Maven > >>> 3.9.9 > >>>> with empty local repo. > >>>> > >>>> Also tried to build nifi against the new nifi-api artifact and found > an > >>>> issue in the nifi nar maven plugin. Currently it cannot handle > >> different > >>>> nifi-api and nifi-framework-api artifact versions. > >>>> Jira [1] has been created to improve the nar plugin. > >>>> > >>>> Thanks for RMing David! > >>>> > >>>> Regards, > >>>> Peter Turcsanyi > >>>> > >>>> [1] https://issues.apache.org/jira/browse/NIFI-13773 >
