It also would be helpful to update the Contributor Guide to indicate to developers when submitting a PR it is necessary to fill out the PR template.
On Fri, Mar 28, 2025 at 1:34 PM Dan S <dsti...@gmail.com> wrote: > Also the Contributor Guide makes mention of submitting a patch file. >> >> Supplying a contribution >> There are currently two paths from which we review and accept >> contributions, ASF JIRA and GitHub Pull Requests (PRs), regardless of >> whether your contribution is source code or documentation (note that >> submitting your contribution through a pull request via GitHub is the >> preferred option as it makes the reviews much easier). > > > Supplying a contribution through patch and JIRA issue >> Assuming you are still on the branch you want to make a patch from >> (NIFI-359) and that you've just committed the change and it is a single >> commit then you can run the following to generate a patch file > > > `git format-patch nifi-359~1 -o </desired/path/for/patch>/nifi-359.patch` > > > Now you can go to JIRA for ticket NIFI-359 and select 'more -> attach >> files' and upload the patch file. Then select 'Submit Patch'. > > > In practice I have experienced this is not the way to submit changes > hence this part should be removed from the Contributor Guide. > > > On Fri, Mar 28, 2025 at 1:29 PM Dan S <dsti...@gmail.com> wrote: > >> Another thing to note is that 1.x is referred to in the Contributor Guide >> and it should be 2.x >> >>> Checkout the 'main' or '1.x.0' branch >>> git checkout -b main origin/main will create a local, tracking branch >>> named main. >>> git checkout -b 0.x origin/1.x.0 will create a local, tracking branch >>> named 1.x.0. >>> >> >> >>> The main branch currently represents the next major release line >>> (1.x.0). >> >> >> On Fri, Mar 28, 2025 at 1:22 PM Dan S <dsti...@gmail.com> wrote: >> >>> The Contributor Guide >>> <https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide> details >>> that documentation is created in AsciiDoc which I believe used to be the >>> case. Aren't we now using Markdown? >>> There are many references to AsciiDoc on that page which should be >>> corrected. >>> >>
