On Wed, Dec 10, 2014 at 8:42 PM, Joe Witt <[email protected]> wrote:
> > That said I do believe we can afford to give up speed if we can trade it > for even higher quality and if we can operate in a manner that is more > conducive to growing a community. Both of which are things we want. For > new features we want folks to have a chance to understand them and provide > alternative views. I also think some of our sense of speed is us tricking > ourselves that fixing bugs quickly means we're fast. It often does just > mean we make bugs fast and as a result we have to fix the fast which on net > is slow...if that makes sense. The more I think about this the more I like > RTC provided we can define the 'review' reasonably. I would like to see a > 'review' be a 'committer' other than yourself independently reviews the > code to ensure it is consistent with the overall design of the application > and so on and flags it as such on the ticket or using a nicely integrated > Jira tool, etc.. > This is what all of the RtC ASF projects I've been exposed to use. The only time something more formal is needed is the situation Joey mentioned, where there is an unreconcilable -1. Those are (and should be) extremely rare because a contributor should be actively seeking compromise positions. Some projects will use a more relaxed standard for "trivial fixes", but that usually ends up being very subjective. For example, fixing a simple NPE might miss adding a test to make sure a regression doesn't happen later. In an active community a +1 for simple changes are usually very quick when everything is lined up nicely. One tool that might ease going RtC is the review tool Gerrit. It can be configured to automatically push to a git repo once a configurable number of binding parties have flagged a change +1, which can help ease the burden of reviewing. I know I've seen other ASF projects consider it, but I don't know if anyone has followed through to see if infra will set things up. Wether Gerrit is available or not, the ASF ReviewBoard works well enough for most cases. -- Sean
