GitHub user rowolabi opened a pull request:
https://github.com/apache/incubator-nifi/pull/39
NIFI-396: StandardProcessSession allows InputStream to be accessed after
returning from callback
Contains fix to prevent clients of the ProcessSession from accessing the
Input/Output Streams it provides once callbacks complete their execution:
- Created a DisableOnCloseInputStream and modified StandardProcessSession
to utilize it
- Updated ProcessSession's javadoc
- Added tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rowolabi/incubator-nifi
inputstream-callback-protection
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-nifi/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 7272d0df58c23d099809bf96993b55d73c617476
Author: Bobby Owolabi <[email protected]>
Date: 2015-03-19T03:30:57Z
NIFI-396 created tests to demonstrate the situations where the
ProcessSession throws an Exception and where it doesn't after it returns from
the callback
commit e2760f8c980583d285137134e05c435c930fb4d2
Author: Bobby Owolabi <[email protected]>
Date: 2015-03-19T04:54:24Z
NIFI-396 added a DisableOnCloseInputStream class; modified
StandardProcessSession to prevent access of the Input/OutputStreams after
callbacks have been executed; updated tests
commit cd183be4410bdc88de7d3a0026452ab62eb10621
Author: Bobby Owolabi <[email protected]>
Date: 2015-03-19T05:18:22Z
NIFI-396 updated the javadocs of ProcessSession to reflect that a
FlowFileAccessExcpetion will be thrown if an Input/Output Stream is attempted
to be accessed after the callback is executed.
commit 3f3623647367421cd8eb318668144aca1afb9bf4
Author: Bobby Owolabi <[email protected]>
Date: 2015-03-19T05:43:17Z
NIFI-396 reverting accidentially modified whitespace in
TestStandardProcessSession
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
