Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/incubator-nifi/pull/55#discussion_r32749012
  
    --- Diff: 
nifi/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/PutKafka.java
 ---
    @@ -136,6 +136,68 @@
                 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
                 .expressionLanguageSupported(false)
                 .build();
    +    public static final PropertyDescriptor PRODUCER_TYPE = new 
PropertyDescriptor.Builder()
    +            .name("Producer Type")
    +            .description("This parameter specifies whether the messages 
are sent asynchronously in a background thread."
    +                    + " Valid values are (1) async for asynchronous send 
and (2) sync for synchronous send."
    +                    + " By setting the producer to async we allow batching 
together of requests (which is great for throughput)"
    +                    + " but open the possibility of a failure of the 
client machine dropping unsent data.")
    +            .required(true)
    +            .allowableValues("sync", "async")
    --- End diff --
    
    We should probably change these to Synchronous and Asynchronous


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to