NLPCraft-ers, Just a clarification (especially, for those who are new to ASF process) - the proposed release needs to be verified by everyone who's voting (whenever possible) so that we can catch these errors quickly. Typically, you need to verify: - signatures (https://www.apache.org/info/verification.html) - tests - examples + major functional areas - license, notice and disclaimer files - license headers in the sources - any other *common sense* checks
Thanks, -- Nikita Ivanov On Thu, Apr 2, 2020 at 12:00 PM Sergey Kamov <[email protected]> wrote: > -1 > > Sorry for previous email > > 1) Test suite isn't passed > All tests passed one by one, but not in suite. "mvn verify" detected 4 > errors. > > [ERROR] Failures: > [ERROR] NCDslTest.test:58 expected: <true> but was: <false> > [ERROR] Errors: > [ERROR] NCEnricherLimitSpec.test:33->NCEnricherBaseSpec.runBatch:135 » > TestFailed Fail... > [ERROR] > NCEnricherNestedModelSpec.test:31->NCEnricherBaseSpec.runBatch:135 » > TestFailed > [ERROR] NCEnricherRelationSpec.test:33->NCEnricherBaseSpec.runBatch:135 > » TestFailed F... > [ERROR] NCEnricherSortSpec.test:33->NCEnricherBaseSpec.runBatch:135 » > TestFailed Faile... > > 2) Unexpected zip file signature. > > >> gpg --verify apache-nlpcraft-incubating-0.5.0.zip.sig > apache-nlpcraft-incubating-0.5.0.zip > > gpg: Signature made Tue Mar 31 09:38:06 2020 MSK > gpg: using RSA key 8EF51E7DC4DF1D751B82C77D3C47CC3F3F4CB613 > gpg: Good signature from "DataLingvo <[email protected]>" [unknown] > gpg: WARNING: This key is not certified with a trusted signature! > gpg: There is no indication that the signature belongs to the > owner. > Primary key fingerprint: 8EF5 1E7D C4DF 1D75 1B82 C77D 3C47 CC3F 3F4C B613 > > > . > > 31.03.2020 23:29, Aaron Radzinski пишет: > > NLPCraft-ers, > > Our first ASF release is ready and up for the vote: > > 1. ZIP tarball > > < > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip > > > > (SHA256 > > < > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256 > >, > > PGP > > < > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sig > > > > ) > > 2. GitHub v0.5.0 tag > > < > https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0 > > > > 3. JIRA resolved issues <http:///> > > > > The vote is formal, see voting guidelines here: > > https://www.apache.org/foundation/voting.html > > +1 - to accept Apache NLPCraft 0.5.0 > > 0 - don't care either way > > -1 - DO NOT accept Apache NLPCraft 0.5.0 (explain why) > > > > See notes on how to verify release here: > > https://www.apache.org/info/verification.html > > > > The vote will be held for 72 hours and will end on April 3rd 2020 at > > midnight MSK. > > > > Thank you! > > -- > > Aaron Radzinski > > >
