[
https://issues.apache.org/jira/browse/NLPCRAFT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084599#comment-17084599
]
Aaron Radzinski commented on NLPCRAFT-37:
-----------------------------------------
# Default behavior is "return true" as a default implementation on this
interface.
# Method 'onMatchedIntent' is only called on probe side. It is the user's
responsibility to check for infinite loop case.
# Not sure how you can avoid throwing NCRejection exception... It's part of
the API contract.
> NCModel#onMatchedIntent behaviour
> ---------------------------------
>
> Key: NLPCRAFT-37
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-37
> Project: NLPCraft
> Issue Type: Improvement
> Components: probe
> Reporter: Sergey Kamov
> Assignee: Aaron Radzinski
> Priority: Major
> Fix For: 0.6.0
>
>
> 1) We can't use super.onMatchedIntent in implementations because NCModel is
> the interface.
> Maybe better to have constant default values?
> 2) If onMatchedIntent returns false and single variant found, we have an
> endless cycle.
> Users can check it on the probe side, but maybe safer to check it on the
> server-side and throw some error?
> 3) onMatchedIntent should return boolean and sometimes throw an exception.
> Maybe better to return some enumeration values? (Note that some `on` methods
> can throw rejection exception, but some can't. )
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
