Furkan - thank you for helping out with this! -- Nikita Ivanov
On Fri, May 22, 2020 at 12:02 PM Furkan KAMACI <furkankam...@gmail.com> wrote: > Hi Aaron, > > Thanks! > > All checks are green now: https://whimsy.apache.org/pods/project/nlpcraft > > Kind Regards, > Furkan KAMACI > > On Fri, May 22, 2020 at 8:36 PM Aaron Radzinski <aradzin...@datalingvo.com > > > wrote: > > > Just FYI, all the latest changes in master are deployed: > > https://nlpcraft.apache.org > > -- > > Aaron Radzinski > > > > > > > > On Fri, May 22, 2020 at 10:34 AM Aaron Radzinski < > > aradzin...@datalingvo.com> > > wrote: > > > > > Oh, I misunderstood. Yes, we'll handle the deployment, of course. > > > > > > Thank you! > > > -- > > > Aaron Radzinski > > > > > > > > > > > > On Fri, May 22, 2020 at 10:24 AM Furkan KAMACI <furkankam...@gmail.com > > > > > wrote: > > > > > >> Hi Aaron, > > >> > > >> I've tested it locally before I send my PR. I thought you guys can > > handle > > >> the deployment. > > >> > > >> Kind Regards, > > >> Furkan KAMACI > > >> > > >> On Fri, May 22, 2020 at 8:21 PM Aaron Radzinski < > > >> aradzin...@datalingvo.com> > > >> wrote: > > >> > > >> > Furkan, > > >> > You can only test it locally (by running 'bundle exec jekyll serve' > in > > >> the > > >> > project root and opening http://127.0.0.1:4000). To deploy you need > > to > > >> do > > >> > branch jiggling (due to asf.yaml odd approach). > > >> > > > >> > Thank you, > > >> > -- > > >> > Aaron Radzinski > > >> > > > >> > > > >> > > > >> > On Thu, May 21, 2020 at 6:44 PM Furkan KAMACI < > furkankam...@gmail.com > > > > > >> > wrote: > > >> > > > >> > > Hi, > > >> > > > > >> > > Website build is not triggered as far as I see? > > >> > > > > >> > > Kind Regards, > > >> > > Furkan KAMACI > > >> > > > > >> > > On Thu, May 21, 2020 at 4:50 AM Furkan KAMACI < > > furkankam...@gmail.com > > >> > > > >> > > wrote: > > >> > > > > >> > > > Hi, > > >> > > > > > >> > > > Seems that there are other errors needs to be corrected > according > > to > > >> > the > > >> > > > clutch analysis: > > https://incubator.apache.org/clutch/nlpcraft.html > > >> > > > > > >> > > > I'll fix them too. > > >> > > > > > >> > > > Kind Regards, > > >> > > > Furkan KAMACI > > >> > > > > > >> > > > On Wed, May 20, 2020 at 10:20 PM Aaron Radzinski < > > >> > > > aradzin...@datalingvo.com> wrote: > > >> > > > > > >> > > >> Merged to master, thank you! > > >> > > >> -- > > >> > > >> Aaron Radzinski > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> On Wed, May 20, 2020 at 8:25 AM Furkan KAMACI < > > >> furkankam...@gmail.com > > >> > > > > >> > > >> wrote: > > >> > > >> > > >> > > >> > Hi Aaron, > > >> > > >> > > > >> > > >> > Here are the reasons: > > >> > > >> > > > >> > > >> > 1) We should use this template for Disclaimer at website: > > >> > > >> > > > >> > > >> > > https://incubator.apache.org/guides/branding.html#disclaimers > > >> > > >> > > > >> > > >> > 2) We should change Sponsors -> Sponsorship at front page. > > >> > > >> > > > >> > > >> > So, I've created a PR for it to contribute the project. > Locally > > >> > tested > > >> > > >> > website and whimsy checks. > > >> > > >> > > > >> > > >> > Let me know if there happen any warnings. > > >> > > >> > > > >> > > >> > Kind Regards, > > >> > > >> > Furkan KAMACI > > >> > > >> > > > >> > > >> > On Thu, May 14, 2020 at 1:42 PM Furkan KAMACI < > > >> > furkankam...@gmail.com > > >> > > > > > >> > > >> > wrote: > > >> > > >> > > > >> > > >> > > Hi Aaron, > > >> > > >> > > > > >> > > >> > > Thanks for the fixes! I'll check the reason of warnings. > > >> > > >> > > > > >> > > >> > > Kind Regards, > > >> > > >> > > Furkan KAMACI > > >> > > >> > > > > >> > > >> > > > > >> > > >> > > > > >> > > >> > > > > >> > > >> > > On Thu, May 14, 2020 at 12:00 PM Aaron Radzinski < > > >> > > >> > > aradzin...@datalingvo.com> wrote: > > >> > > >> > > > > >> > > >> > >> Fixed: https://whimsy.apache.org/pods/project/nlpcraft > > >> > > >> > >> > > >> > > >> > >> (there are some warnings - but I think it's whimsy > related). > > >> > > >> > >> > > >> > > >> > >> Thank you, > > >> > > >> > >> -- > > >> > > >> > >> Aaron Radzinski > > >> > > >> > >> > > >> > > >> > >> > > >> > > >> > >> > > >> > > >> > >> On Wed, May 13, 2020 at 10:13 AM Furkan KAMACI < > > >> > > >> furkankam...@gmail.com> > > >> > > >> > >> wrote: > > >> > > >> > >> > > >> > > >> > >> > Hi All, > > >> > > >> > >> > > > >> > > >> > >> > First of all, I am really happy about the current status > > of > > >> the > > >> > > >> > project > > >> > > >> > >> > as a mentor. As a next step, I would like to suggest > > finish > > >> > these > > >> > > >> > tasks: > > >> > > >> > >> > https://whimsy.apache.org/pods/project/nlpcraft (you > may > > >> not > > >> > > have > > >> > > >> > >> noticed > > >> > > >> > >> > before). > > >> > > >> > >> > > > >> > > >> > >> > These are not necessary before graduation but should be > > done > > >> > > until > > >> > > >> > then. > > >> > > >> > >> > So, it is a good practice to finish such things one by > one > > >> when > > >> > > you > > >> > > >> > have > > >> > > >> > >> > time. > > >> > > >> > >> > > > >> > > >> > >> > Please feel free to ask if you have any questions. > > >> > > >> > >> > > > >> > > >> > >> > Kind Regards, > > >> > > >> > >> > Furkan KAMACI > > >> > > >> > >> > > > >> > > >> > >> > > >> > > >> > > > > >> > > >> > > > >> > > >> > > >> > > > > > >> > > > > >> > > > >> > > > > > >
