+1 Checked hashes and signatures DISCLAIMER exists NOTICE seems okay LICENSE is okay but I think can be further improved (see [1] below) "mvn clean package verify" passes on Ubuntu and Win10 (no VM crash on Win10 this time - yay) "mvn apache-rat:rat" passes incubating in name no unexpected binary files I ran against some pre-existing examples (see [2] below)
[1] I believe the first mention of src/main/resources/moby in LICENSE can be removed. The second mention is now more detailed and should be retained however I don't believe it would be usual to relicense the mobi works from public domain to Apache 2.0. The mention in the NOTICE file allows you to include those resources without further re-licensing. I would suggest removing "and licensed under Apache License, Version 2.0" unless of course you have a specific reasoning behind wanting to re-license those artifacts. [2] I also ran my nlpcraft groovy-data-science example which interacts with the light switch example model. After adding in a kotlin-stdlib dependency, it ran fine against the Java, Scala, Kotlin and Groovy example models. I had to add the language to each respective model ID, e.g. nlpcraft.lightswitch.ex.groovy instead of nlpcraft.lightswitch.ex which I have used in the past. Cheers, Paul. On Sat, May 8, 2021 at 9:43 AM Aaron Radzinski <[email protected]> wrote: > NLPCraft-ers, > We have finally finished with the massive 0.7.5 release and are ready to > make it public. This release constitutes the biggest change since the > project inception at ASF over a year ago. This is a call for a vote to > release Apache NLPCraft (incubating) version 0.7.5. This release includes > many significant improvements and bug fixes. > > Release information: > 1. Release location: > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.5/ > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.5 > 4. JIRA issues fixed in release: > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349604 > 5. KEYS file: > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS > > The vote will be open for at least 72 hours or until a necessary number of > votes are reached. > > Please vote accordingly: > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thank you, > -- > Aaron Radzinski >
