Hello, Aaron, thanks for the email on this. For the sake of context, I was looking at the Apache Ignite project git repo and I saw that having clickable links to the JIRA ticket on the master branch commits looked very organized (they even have the link to the pull request on the commits as well). I think if we can start doing this going forward, for the master branch, it would cascade into having a more organized project.
-Rahul On 7/2/21 2:33 PM, Aaron Radzinski wrote: I guess this works too. -- Aaron Radzinski On Fri, Jul 2, 2021 at 11:16 AM Sergey Kamov <[email protected]><mailto:[email protected]> wrote: Hi. Do we really need it if we use squash commits ? Usually I use WIP comment for intermediate commits in the working branch, and on squash commit phase ( to master branch) more detailed message. This detailed message can be extended by ticket number i guess. Regards, Sergey чт, 1 июл. 2021 г., 23:52 Aaron Radzinski <[email protected]><mailto:[email protected]>: NLPCraft-ers, Thanks for Rahul for pointing out that our implicit practice on using a default "WIP" commit message is rather not informative and it pollutes Git history. I would suggest the community adopts the rule by which we always add a ticket number (i.e. branch numbers) to the commit message, i.e. "WIP" => "WIP on NLPCRAFT-123". This way the Git history becomes much more descriptive. Thoughts? -- Aaron Radzinski
