[
https://issues.apache.org/jira/browse/NLPCRAFT-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390840#comment-17390840
]
Aaron Radzinski commented on NLPCRAFT-382:
------------------------------------------
Strike through items are fixed in master.
> Fix release process based on 0.9.0 vote comments.
> --------------------------------------------------
>
> Key: NLPCRAFT-382
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-382
> Project: NLPCraft
> Issue Type: Task
> Components: build & release
> Reporter: Aaron Radzinski
> Assignee: Sergey Kamov
> Priority: Critical
> Fix For: 0.9.1
>
>
> {color:#222222}+1 but only due to work in progress disclaimer. There are
> serval minor issues that need to be fixed.{color}
> {color:#222222}I checked:{color}
> {color:#222222}- incubating in name{color}
> {color:#222222}- signatures and hashes good{color}
> {color:#222222}- disclaimer exists{color}
> -{color:#222222}- license is missing information on a file [6]{color}-
> -{color:#222222}- NOTICE is not correct. As mentioned on a previous release
> [1] there is no need to list licenses or unneeded copyright statement in
> NOTICE. If this is not fixed in a future release I will vote -1 on it.{color}-
> *{color:#222222}- source release contains compiled code [2][3][4][5]{color}*
> -{color:#222222}- This file incorrectly has an ASF header [6] and should be
> mention in LICENSE{color}-
> {color:#222222}This release is hard to review as for some reason rat doesn’t
> recognise the headers on the scala files. This may have hidden some other
> issues.{color}
> {color:#222222}Kind Regards,{color}
> {color:#222222}Justin{color}
> {color:#222222}1.
> {color}[https://lists.apache.org/thread.html/rf79136697625906cdbf723eeed3b710eb6f4256a39493bbc715238a0%40%3Cgeneral.incubator.apache.org%3E]
> {color:#222222}2.
> ./nlpcraft/src/main/python/ctx{color}{color:#222222}word/__pycache__/server.cpytho{color}{color:#222222}n-38.pyc{color}
> {color:#222222}3.
> ./nlpcraft/src/main/python/ctx{color}{color:#222222}word/bertft/__pycache__/__init{color}{color:#222222}__.cpython-38.pyc{color}
> {color:#222222}4.
> ./nlpcraft/src/main/python/ctx{color}{color:#222222}word/bertft/__pycache__/bertft{color}{color:#222222}.cpython-38.pyc{color}
> {color:#222222}5.
> ./nlpcraft/src/main/python/ctx{color}{color:#222222}word/bertft/__pycache__/utils.{color}{color:#222222}cpython-38.pyc{color}
> {color:#222222}6.
> ./nlpcraft/src/main/scala/org/{color}{color:#222222}apache/nlpcraft/common/util/NC{color}{color:#222222}IdGenerator.java{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
