rahul3 commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902813969
@nivanov > I think we should start with "everything in maven" approach. It should download/install everything when it detects that something Python related is missing. This is how it is currently built in this pull request. > I don't like the idea of a non-standard command to build the project. I think we should try to retain the standard "mvn clean package" idiom. To clarify, `mvn clean package` builds the project even with this pull request. However, to run the `verify` phase, you would have to clean it again because of the way FastText is designed to be installed. It is via a `git clone <fast-text-repo>`. It is somewhat non-standard and I've checked that it has issues cross-platform (Windows specifically) if it is done via `pip`. This is in the [FastText official documentation](https://fasttext.cc/docs/en/support.html). I could also add another folder deletion in the verify phase so that `mvn clean package verify` would work. Let me know if that is what you would prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
