Hello Nmap Developers, As suggested in CONTRIBUTION.md i am writing this mail to notify about my PR https://github.com/nmap/nmap/pull/3277
This PR refactors and fixes the POP3 authentication helper functions used by NSE scripts, including pop3-brute.nse. Main changes: - Hardened SASL LOGIN handling - Improved SASL PLAIN and CRAM-MD5 logic - Corrected APOP handling and report missing OpenSSL support - Normalized return values and error handling - Cleaned up legacy logic Scope: - Only refactors nselib/pop3.lua - Does not modify pop3-brute.nse directly - Does not implement STLS or automatic auth selection This is intended as a small cleanup to make future improvements to pop3-brute.nse easier (related to issue #2158). The PR has no conflicts and CI is waiting for maintainer approval. I would appreciate any review or feedback when you have time. I am happy to update the patch if needed. Thank you for your time. Best regards, Sweekar
_______________________________________________ Sent through the dev mailing list https://nmap.org/mailman/listinfo/dev Archived at https://seclists.org/nmap-dev/
