[ 
https://issues.apache.org/jira/browse/NUTCH-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086375#comment-13086375
 ] 

Kay Kay commented on NUTCH-1079:
--------------------------------

Well - the string+string concat would still translate to a StringBuilder and 
not a StringBuffer, as per javase compiler at least. (agree about the 
unnecessary extra instantiation of the empty StringBuilder ,  that happens as 
part of it though). 

Would it be acceptable if we revisit, those independent appends on a priority 
basis (starting with all the non, toString() methods ), in a different jira, 
say ? 

> StringBuffer converted to StringBuilder
> ---------------------------------------
>
>                 Key: NUTCH-1079
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1079
>             Project: Nutch
>          Issue Type: Bug
>          Components: fetcher, indexer
>    Affects Versions: 1.3
>            Reporter: Kay Kay
>            Assignee: Markus Jelsma
>             Fix For: 1.4
>
>         Attachments: NUTCH-1079.patch, NUTCH-rel_14-1079.patch
>
>
> All across the codebase, it contains StringBuffer, when thread-safety is 
> probably not intended. 
> This patch replaces StringBuffer to StringBuilder, as applicable. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to