[ 
https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113328#comment-13113328
 ] 

Lewis John McGibbney commented on NUTCH-1078:
---------------------------------------------

This is a pretty tricky case of the following
{code}
only messages of type String are supported

If one of your log statements contains a non-string object as its sole 
parameter, you will have to manually add a toString() method call on the object.

For example,

logger.debug(new Object());

has to be manually re-written as

logger.debug(new Object().toString()); 
{code}

There are quite a few examples of this in fetcher.java I'll start working my 
way through them and get a patch submitted later today Markus.

> Upgrade all instances of commons logging to slf4j (with log4j backend)
> ----------------------------------------------------------------------
>
>                 Key: NUTCH-1078
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1078
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: NUTCH-1078-branch-1.4-20110816.patch, 
> NUTCH-1078-branch-1.4-20110824-v2.patch, 
> NUTCH-1078-branch-1.4-20110911-v3.patch, 
> NUTCH-1078-branch-1.4-20110916-v4.patch
>
>
> Whilst working on another issue, I noticed that some classes still import and 
> use commons logging for example HttpBase.java
> {code}
> import java.util.*;
> // Commons Logging imports
> import org.apache.commons.logging.Log;
> import org.apache.commons.logging.LogFactory;
> // Nutch imports
> import org.apache.nutch.crawl.CrawlDatum;
> {code}
> At this stage I am unsure how many (if any others) still import and reply 
> upon commons logging, however they should be upgraded to slf4j for branch-1.4.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to