[ 
https://issues.apache.org/jira/browse/NUTCH-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150451#comment-13150451
 ] 

Ferdy Galema commented on NUTCH-1184:
-------------------------------------

Hi Markus,

This functionality is very useful. A few notes:

bq.do not normalize and filter in ParseOutputFormat if fetcher.parse = true
Did you implement this too? If so please note that the current patch (both 
1.5-5 files) does not include this. If you didn't, I think this would be a nice 
addition. (Otherwise with fetcher.parse enabled normalizing and filtering will 
be done twice, right?). And a minor suggestion is to perhaps create a common 
method for the outlink iteration, to avoid duplicate code.

Other then that, the changes look good.
                
> Fetcher to parse and follow Nth degree outlinks
> -----------------------------------------------
>
>                 Key: NUTCH-1184
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1184
>             Project: Nutch
>          Issue Type: New Feature
>          Components: fetcher
>            Reporter: Markus Jelsma
>            Assignee: Markus Jelsma
>             Fix For: 1.5
>
>         Attachments: NUTCH-1184-1.5-1.patch, NUTCH-1184-1.5-2.patch, 
> NUTCH-1184-1.5-3.patch, NUTCH-1184-1.5-4.patch, 
> NUTCH-1184-1.5-5-ParseData.patch, NUTCH-1184-1.5-5.patch
>
>
> Improvements to fetcher to follow Nth degree outlinks of fetched items:
> - fetch
> - parse
> - normalize and filter outlinks
> - create new FetchItem and inject in the queue

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to