[
https://issues.apache.org/jira/browse/NUTCH-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211320#comment-13211320
]
Lewis John McGibbney commented on NUTCH-1278:
---------------------------------------------
Behnam, this looks interesting but there are a few problems here.
1) It would be much much easier for us to apply, test and comment on your
contribution if you included it in a simple .patch file. This can be done like
so
{code}
$ cd $NUTCH_HOME
$ svn diff > NUTCH-patch-name.patch
{code}
The current zip format for the patch(es), plus the fact that every class has
been patched separately from thier own respective directories makes it really
hard for us to work with this.
2) I doesn't appear that this patch is actually applies against trunk? Maybe
1.4? You can check out trunk here [1] I'm getting errors when trying to apply
HttpBase then gave up and started writing this.
3) for a change to the fetcher of this scale, it would be really nice if you
could provide a test within the test suite we already maintain [2].
As I said this looks really great, and sorry for the rather lengthy initial
response, but for us to consider this for integration it would be great for
your contributions to meet this minimum requirement as they are highly
appreciated. Thank you
[1] https://svn.apache.org/repos/asf/nutch/trunk/
[2]
https://svn.apache.org/viewvc/nutch/trunk/src/test/org/apache/nutch/fetcher/TestFetcher.java?view=markup
> Fetch Improvement in threads per host
> -------------------------------------
>
> Key: NUTCH-1278
> URL: https://issues.apache.org/jira/browse/NUTCH-1278
> Project: Nutch
> Issue Type: New Feature
> Components: fetcher
> Affects Versions: 1.4
> Reporter: behnam nikbakht
> Attachments: NUTCH-1278.zip
>
>
> the value of maxThreads is equal to fetcher.threads.per.host and is constant
> for every host
> there is a possibility with using of dynamic values for every host that
> influeced with number of blocked requests.
> this means that if number of blocked requests for one host increased, then we
> most decrease this value and increase http.timeout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
