[ 
https://issues.apache.org/jira/browse/NUTCH-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262496#comment-13262496
 ] 

Ferdy Galema commented on NUTCH-902:
------------------------------------

I think nutch-default.xml does not correctly use the description field of the 
"storage.data.store.class" property. The description should describe what the 
property is about, not what the value is about. So instead of the various 
entries:

<property>
  <name>storage.data.store.class</name>
  <value>org.apache.gora.cassandra.store.CassandraStore</value>
  <description>Gora class for storing data in Apache Cassandra</description>
</property>
-->

<!--
<property>
  <name>storage.data.store.class</name>
  <value>org.apache.gora.hbase.store.HBaseStore</value>
  <description>Gora class for storing data in Apache HBase</description>
</property>
-->

so on..

I propose to add a single property entry with the following description like 
this:

<property>
  <name>storage.data.store.class</name>
  <value>org.apache.gora.sql.store.SqlStore</value>
  <description>The Gora DataStore class for storing/retrieving data.
    Currently the following stores are available:

    org.apache.gora.sql.store.SqlStore
      A DataStore implementation for RDBMS with a SQL interface.
      SqlStore uses JDBC drivers to communicate with the DB.

    org.apache.gora.hbase.store.HBaseStore
      DataStore implementation for Hadoop HBase.

    etcetera

  </description>
</property>

This has the additional benefit to make the nutch-default.xml look cleaner, 
imho.
                
> Add all necessary files and configuration so that nutch can be used with 
> different backends out-of-the-box
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: NUTCH-902
>                 URL: https://issues.apache.org/jira/browse/NUTCH-902
>             Project: Nutch
>          Issue Type: New Feature
>          Components: documentation, storage
>    Affects Versions: nutchbase
>            Reporter: Enis Soztutar
>            Assignee: Lewis John McGibbney
>             Fix For: nutchgora
>
>         Attachments: NUTCH-902-v2.patch, NUTCH-902-v3.patch, NUTCH-902.patch
>
>
> As per the discussion in the mailing list and 
> http://wiki.apache.org/nutch/GORA_HBase, it will be good to include all the 
> necessary files and configuration. I propose that we maintain configuration 
> for at least SQL, HBase and Cassandra. 
> The following changes are needed:
> conf/gora-sql-mapping.xml
> conf/gora-hbase-mapping.xml
> conf/gora-cassandra-mapping.xml
> comments on nutch-default and ivy.xml 
> Shall we also include jars from gora-hbase, gora-cassandra and their 
> dependencies ? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to