[ https://issues.apache.org/jira/browse/NUTCH-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262592#comment-13262592 ]
Lewis John McGibbney commented on NUTCH-1306: --------------------------------------------- Having reviewed similar work that has been integrated in 1.X trunk (namely the issues I highlight above) we should remain consistent with principal that we should either commit always and have an option not to commit, or the other way around. Since NutchGora doesn't commit at all, we favour the option to commit instead a noCommit, then with the option to do a noCommit by configuration. It's at least clear it should be configurable one way or the other. Never committing or always committing is bad. (Thanks Markus for the input) > Commit after finished writing to solr index > ------------------------------------------- > > Key: NUTCH-1306 > URL: https://issues.apache.org/jira/browse/NUTCH-1306 > Project: Nutch > Issue Type: Improvement > Components: indexer > Affects Versions: nutchgora > Reporter: Dan Rosher > Priority: Trivial > Fix For: 2.1 > > Attachments: NUTCH-1306.patch > > > Commit after finished writing to solr index - otherwise a bit confusing not > seeing the number of docs we expect in solr -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira