[
https://issues.apache.org/jira/browse/NUTCH-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433955#comment-13433955
]
Ferdy Galema commented on NUTCH-1442:
-------------------------------------
Thanks. Looks fine.
Assertions should not always be needed. (Sometimes running tests without
throwing exceptions is fine enough). In this case, I'm not sure. The test justs
indexes a single document. Also notice the statement in comments from Nutch
trunk. That one should be removed at least. This can be addressed in another
issue for improving the test.
> indexingfilter.order is property is misread in code
> ---------------------------------------------------
>
> Key: NUTCH-1442
> URL: https://issues.apache.org/jira/browse/NUTCH-1442
> Project: Nutch
> Issue Type: Bug
> Reporter: Ferdy Galema
> Assignee: Lewis John McGibbney
> Fix For: 2.1
>
> Attachments: NUTCH-1442.patch
>
>
> The property for indexfilters order is defined as indexingfilter.order in
> nutch-default, however the code in IndexingFilters tries to read it as
> indexingfilterhbase.order. Clearly this is an artifact from the past and
> should be fixed asap.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira