Hi Lewis, I am not sure about what needs to be done for #3 and #5. So I left it as an open question. Once we reach a common understanding, I will open a jira for this.
Thanks, Tejas Patil On Mon, Feb 25, 2013 at 1:17 PM, Lewis John Mcgibbney < [email protected]> wrote: > Hi Tejas, > > On Sun, Feb 24, 2013 at 6:27 PM, <[email protected]> wrote: > >> Hi Lewis, >> >> We have not came to a conclusion for this topic. >> > > Correct, thanks for pushing this one! > > >> Here is what I propose: >> 1. keep "generate.max.count" >> 2. GENERATOR_MIN_SCORE and GENERATOR_MAX_COUNT: once we get to know that >> if they were kept back in 2.x for some valid reason, then we can safely >> remove these params. These seem to do nothing meaningful. >> 3. generate.min.score : remove ? >> 4. generate.filter, generate.normalise, generate.topN : there is not >> problem in keeping it. we can even remove it. >> 5. GENERATOR_COUNT_VALUE_IP : ?? >> >> I agree this Tejas. Maybe we can open an issue on this and record it? > > Lewis >
