[ 
https://issues.apache.org/jira/browse/NUTCH-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701879#comment-13701879
 ] 

Markus Jelsma commented on NUTCH-1604:
--------------------------------------

+1 runs fine! 
                
> ProtocolFactory not thread-safe
> -------------------------------
>
>                 Key: NUTCH-1604
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1604
>             Project: Nutch
>          Issue Type: Bug
>          Components: fetcher
>    Affects Versions: 1.7, 2.2.1
>            Reporter: Julien Nioche
>             Fix For: 2.3, 1.8
>
>         Attachments: NUTCH-1604.2.x.patch, NUTCH-1604.patch
>
>
> The method getProtocol() should be synchronized otherwise the Fetcher threads 
> can access it around the same time and query the cache before it's had a 
> chance of being populated properly. This would happen for a handful of calls 
> until the subsequent ones get the cache but this should be fixed nonetheless 
> e.g. when we want a guarantee that the same Protocol instance will be called 
> for the same fetching session.
> The other Factor classes which use the same cache mechanism would suffer from 
> the same problem.    

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to