[
https://issues.apache.org/jira/browse/NUTCH-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806486#comment-13806486
]
Sebastian Nagel commented on NUTCH-1645:
----------------------------------------
-1
It's still mostly a port of AdaptiveFetchSchedule's main() from 1.x which is
supposed to test and adjust configuration properties. The unit test checks for
equality of some "key statistics", eg., the total number of misses must be
equal to 4189. That's a rather arbitrary number. An improved implementation
which reaches a lower number of misses would cause the test to fail. A "status
quo" may be useful if many classes interact, and regressions may get into as
side-effects of changes elsewhere. But do we need a test class of 200 lines to
test the status quo of 100 lines of code? And tacitly allow that these 100
lines contain at least one bug (NUTCH-1564)? A unit test which makes the sync
delta problem reproducible and allows to verify fixes would be really useful.
Also code style conventions are not follow and there are typos
("...Feffftch...").
> Junit Test Case for Adaptive Fetch Schedule class
> -------------------------------------------------
>
> Key: NUTCH-1645
> URL: https://issues.apache.org/jira/browse/NUTCH-1645
> Project: Nutch
> Issue Type: Test
> Affects Versions: 2.2.1
> Reporter: Talat UYARER
> Priority: Minor
> Fix For: 2.3
>
> Attachments: NUTCH-1645.patch, NUTCH-1645-v2.patch
>
>
> Currently there is not Test Case for Adaptive Fetch Schedule. Junit test
> Writes for its.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
