[ 
https://issues.apache.org/jira/browse/NUTCH-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151595#comment-14151595
 ] 

Sebastian Nagel commented on NUTCH-1857:
----------------------------------------

-1 The patch breaks the {{-topN ... <min>}} option:
* :"db.reader.topn.min" is set as float but still read as long
* the way to pass a float via a long multiplied by 1Mio. is unnecessary complex 
if the currently used Hadoop version has a setFloat. But it would be better to 
fix this in a separate issue.

Ok to use a comma instead of semicolon (that's most of the patch :))

> readb -dump -format csv should use comma
> ----------------------------------------
>
>                 Key: NUTCH-1857
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1857
>             Project: Nutch
>          Issue Type: New Feature
>          Components: crawldb
>    Affects Versions: 1.9
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>             Fix For: 1.10
>
>         Attachments: NUTCH-1857.patch
>
>
> The -dump -format csv option currently uses ASCII character ';' %3B which is 
> not a comma but instead a semi-colon.
> This is a pain in the back side as I always need to override this within the 
> Solr update request.
> We should change the behavhiour to default to the common comma... as 
> indicated here
> http://www.ietf.org/rfc/rfc4180.txt



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to