[ 
https://issues.apache.org/jira/browse/NUTCH-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257188#comment-14257188
 ] 

Hudson commented on NUTCH-1834:
-------------------------------

SUCCESS: Integrated in Nutch-nutchgora #1278 (See 
[https://builds.apache.org/job/Nutch-nutchgora/1278/])
NUTCH-1834 GeneratorMapper behavior depends on log level (snagel: 
http://svn.apache.org/viewvc/nutch/branches/2.x/?view=rev&rev=1647602)
* /nutch/branches/2.x/CHANGES.txt
* /nutch/branches/2.x/src/java/org/apache/nutch/crawl/GeneratorMapper.java


> GeneratorMapper behavior depends on log level
> ---------------------------------------------
>
>                 Key: NUTCH-1834
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1834
>             Project: Nutch
>          Issue Type: Bug
>          Components: generator
>    Affects Versions: 2.2.1
>            Reporter: Gerhard Gossen
>            Assignee: Sebastian Nagel
>             Fix For: 2.3
>
>         Attachments: NUTCH-1834.patch
>
>
> In GeneratorMapper, two {{return}} statements are shifted by a line so that 
> they end up in a {{if (LOG.isWarnEnabled())}} block. Therefore a change of 
> the log level will change the behavior of the generator, i.e. an URL where an 
> IndexFilters throws an exception will still be generated.
> The attached patch removes the {{if}} block completely by using SLF4J's 
> placeholders. This avoids the unnecessary string concatenations that made the 
> {{if}} necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to