[ 
https://issues.apache.org/jira/browse/NUTCH-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350079#comment-14350079
 ] 

ASF GitHub Bot commented on NUTCH-1946:
---------------------------------------

Github user jeroenvlek commented on a diff in the pull request:

    https://github.com/apache/gora/pull/21#discussion_r25929774
  
    --- Diff: gora-hbase/pom.xml ---
    @@ -117,6 +117,18 @@
     
         <dependency>
           <groupId>org.apache.hbase</groupId>
    +      <artifactId>hbase-common</artifactId>
    +      <scope>compile</scope>
    +      <exclusions>
    +        <exclusion>
    +          <groupId>org.slf4j</groupId>
    +          <artifactId>slf4j-log4j12</artifactId>
    --- End diff --
    
    http://basementcoders.com/2010/05/maven-exclusions-not-always-inherited/
    
    It depends. According to the link above, this exclusion actually causes the 
other exclusions in the main pom.xml to be *included* again. Is that on 
purpose? Do we then still need the other exclusions in the parent pom.xml?
    
    My knowledge of Maven runs a bit short here. The difference with the 
example in the link above, is that  in the parent pom one exclusion is stated 
in a dependency management section, and the child pom just states its 
dependencies.


> Upgrade to Gora 0.6.1
> ---------------------
>
>                 Key: NUTCH-1946
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1946
>             Project: Nutch
>          Issue Type: Improvement
>          Components: storage
>    Affects Versions: 2.3.1
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>             Fix For: 2.3.1
>
>         Attachments: NUTCH-1946.patch, NUTCH-1946_Gora_fixes.patch, 
> NUTCH-1946v2.patch, NUTCH-1946v3.patch
>
>
> Apache Gora was released recently.
> We should upgrade before pushing Nutch 2.3.1 as it will come in very handy 
> for the new Docker containers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to