[ 
https://issues.apache.org/jira/browse/NUTCH-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501113#comment-14501113
 ] 

Chris A. Mattmann commented on NUTCH-1973:
------------------------------------------

[~sujenshah] this patch doesn't apply cleanly, FYI:

{noformat}
[chipotle:~/tmp/nutch-1.10-trunk] mattmann% curl -O 
https://patch-diff.githubusercontent.com/raw/apache/nutch/pull/16.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  256k    0  256k    0     0   153k      0 --:--:--  0:00:01 --:--:--  153k
[chipotle:~/tmp/nutch-1.10-trunk] mattmann% git apply < 16.patch 
<stdin>:568: trailing whitespace.
                         * 
<stdin>:812: trailing whitespace.
         * 
<stdin>:822: trailing whitespace.
         * 
<stdin>:883: trailing whitespace.
        
<stdin>:999: trailing whitespace.
        
error: patch failed: src/java/org/apache/nutch/service/NutchServer.java:34
error: src/java/org/apache/nutch/service/NutchServer.java: patch does not apply
error: patch failed: 
src/java/org/apache/nutch/service/resources/JobResource.java:26
error: src/java/org/apache/nutch/service/resources/JobResource.java: patch does 
not apply
error: patch failed: src/java/org/apache/nutch/service/NutchServer.java:20
error: src/java/org/apache/nutch/service/NutchServer.java: patch does not apply
error: patch failed: 
src/java/org/apache/nutch/service/resources/JobResource.java:63
error: src/java/org/apache/nutch/service/resources/JobResource.java: patch does 
not apply
error: patch failed: src/java/org/apache/nutch/crawl/CrawlDbReader.java:61
error: src/java/org/apache/nutch/crawl/CrawlDbReader.java: patch does not apply
error: patch failed: src/java/org/apache/nutch/service/NutchServer.java:40
error: src/java/org/apache/nutch/service/NutchServer.java: patch does not apply
error: patch failed: src/java/org/apache/nutch/crawl/CrawlDbReader.java:39
error: src/java/org/apache/nutch/crawl/CrawlDbReader.java: patch does not apply
error: patch failed: src/java/org/apache/nutch/crawl/CrawlDbReader.java:424
error: src/java/org/apache/nutch/crawl/CrawlDbReader.java: patch does not apply
error: patch failed: src/java/org/apache/nutch/crawl/CrawlDbReader.java:716
error: src/java/org/apache/nutch/crawl/CrawlDbReader.java: patch does not apply
error: patch failed: src/java/org/apache/nutch/crawl/CrawlDbReader.java:716
error: src/java/org/apache/nutch/crawl/CrawlDbReader.java: patch does not apply
error: patch failed: src/java/org/apache/nutch/service/NutchServer.java:50
error: src/java/org/apache/nutch/service/NutchServer.java: patch does not apply
error: patch failed: 
src/java/org/apache/nutch/service/resources/ConfigResource.java:38
error: src/java/org/apache/nutch/service/resources/ConfigResource.java: patch 
does not apply
error: patch failed: src/java/org/apache/nutch/crawl/CrawlDbReader.java:796
error: src/java/org/apache/nutch/crawl/CrawlDbReader.java: patch does not apply
error: patch failed: src/java/org/apache/nutch/crawl/CrawlDbReader.java:720
error: src/java/org/apache/nutch/crawl/CrawlDbReader.java: patch does not apply
error: patch failed: src/java/org/apache/nutch/service/NutchServer.java:43
error: src/java/org/apache/nutch/service/NutchServer.java: patch does not apply
[chipotle:~/tmp/nutch-1.10-trunk] mattmann% svn status
?       16.patch
[chipotle:~/tmp/nutch-1.10-trunk] mattmann% patch -p1 < 16.patch 
patching file src/java/org/apache/nutch/crawl/Injector.java
patching file src/java/org/apache/nutch/service/model/response/JobConfig.java
patching file src/java/org/apache/nutch/util/NutchTool.java
patching file src/java/org/apache/nutch/service/NutchServer.java
Hunk #1 succeeded at 35 with fuzz 1 (offset 1 line).
Hunk #2 succeeded at 60 (offset 2 lines).
Hunk #3 succeeded at 71 (offset 2 lines).
Hunk #4 succeeded at 126 (offset 2 lines).
patching file src/java/org/apache/nutch/service/resources/AbstractResource.java
patching file src/java/org/apache/nutch/metadata/Nutch.java
patching file src/java/org/apache/nutch/service/JobManager.java
patching file src/java/org/apache/nutch/service/impl/JobFactory.java
patching file src/java/org/apache/nutch/service/impl/JobManagerImpl.java
patching file src/java/org/apache/nutch/service/impl/JobWorker.java
patching file src/java/org/apache/nutch/service/model/response/JobInfo.java
patching file src/java/org/apache/nutch/service/resources/JobResource.java
Hunk #1 FAILED at 26.
Hunk #2 succeeded at 70 (offset 4 lines).
1 out of 2 hunks FAILED -- saving rejects to file 
src/java/org/apache/nutch/service/resources/JobResource.java.rej
patching file src/java/org/apache/nutch/service/model/request/JobConfig.java
patching file src/java/org/apache/nutch/crawl/CrawlDb.java
patching file src/java/org/apache/nutch/crawl/DeduplicationJob.java
patching file src/java/org/apache/nutch/crawl/Generator.java
patching file src/java/org/apache/nutch/crawl/Injector.java
patching file src/java/org/apache/nutch/crawl/LinkDb.java
patching file src/java/org/apache/nutch/fetcher/Fetcher.java
patching file src/java/org/apache/nutch/parse/ParseSegment.java
patching file src/java/org/apache/nutch/service/JobManager.java
patching file src/java/org/apache/nutch/service/NutchServer.java
Hunk #1 succeeded at 20 with fuzz 2.
Hunk #2 FAILED at 38.
Hunk #3 succeeded at 76 (offset 2 lines).
Hunk #4 succeeded at 116 with fuzz 1 (offset 2 lines).
Hunk #5 succeeded at 137 (offset 2 lines).
1 out of 5 hunks FAILED -- saving rejects to file 
src/java/org/apache/nutch/service/NutchServer.java.rej
patching file src/java/org/apache/nutch/service/impl/JobFactory.java
patching file src/java/org/apache/nutch/service/impl/JobManagerImpl.java
patching file 
src/java/org/apache/nutch/service/impl/NutchServerPoolExecutor.java
patching file src/java/org/apache/nutch/util/NutchTool.java
patching file src/java/org/apache/nutch/crawl/CrawlDb.java
patching file src/java/org/apache/nutch/crawl/DeduplicationJob.java
patching file src/java/org/apache/nutch/crawl/Generator.java
patching file src/java/org/apache/nutch/crawl/Injector.java
patching file src/java/org/apache/nutch/crawl/LinkDb.java
patching file src/java/org/apache/nutch/fetcher/Fetcher.java
patching file src/java/org/apache/nutch/parse/ParseSegment.java
patching file src/java/org/apache/nutch/service/impl/JobFactory.java
patching file src/java/org/apache/nutch/service/impl/JobManagerImpl.java
patching file src/java/org/apache/nutch/service/model/response/JobInfo.java
patching file src/java/org/apache/nutch/service/resources/JobResource.java
Hunk #1 succeeded at 67 (offset 4 lines).
patching file src/java/org/apache/nutch/crawl/CrawlDbReader.java
Hunk #3 succeeded at 72 with fuzz 1 (offset 2 lines).
Hunk #4 FAILED at 355.
Hunk #5 succeeded at 425 (offset 2 lines).
Hunk #6 succeeded at 512 (offset 2 lines).
Hunk #7 FAILED at 770.
2 out of 7 hunks FAILED -- saving rejects to file 
src/java/org/apache/nutch/crawl/CrawlDbReader.java.rej
patching file src/java/org/apache/nutch/service/JobManager.java
patching file src/java/org/apache/nutch/service/NutchServer.java
Hunk #1 succeeded at 40 with fuzz 2.
Hunk #2 succeeded at 118 (offset -1 lines).
patching file src/java/org/apache/nutch/service/model/request/DbQuery.java
patching file src/java/org/apache/nutch/service/resources/DbResource.java
patching file src/java/org/apache/nutch/util/NutchTool.java
patching file src/java/org/apache/nutch/crawl/CrawlDbReader.java
Hunk #3 FAILED at 775.
Hunk #4 FAILED at 799.
Hunk #5 FAILED at 832.
3 out of 5 hunks FAILED -- saving rejects to file 
src/java/org/apache/nutch/crawl/CrawlDbReader.java.rej
patching file src/java/org/apache/nutch/service/resources/DbResource.java
patching file src/java/org/apache/nutch/crawl/CrawlDb.java
patching file src/java/org/apache/nutch/crawl/CrawlDbReader.java
Hunk #1 succeeded at 363 (offset -61 lines).
Hunk #2 succeeded at 392 (offset -61 lines).
patching file src/java/org/apache/nutch/crawl/Injector.java
patching file src/java/org/apache/nutch/fetcher/Fetcher.java
patching file src/java/org/apache/nutch/parse/ParseSegment.java
patching file 
src/java/org/apache/nutch/service/impl/NutchServerPoolExecutor.java
patching file src/java/org/apache/nutch/service/model/request/DbQuery.java
patching file src/java/org/apache/nutch/service/resources/DbResource.java
patching file src/java/org/apache/nutch/util/NutchTool.java
patching file src/java/org/apache/nutch/parse/ParseSegment.java
patching file src/java/org/apache/nutch/crawl/CrawlDbReader.java
Hunk #1 FAILED at 716.
Hunk #2 FAILED at 775.
2 out of 2 hunks FAILED -- saving rejects to file 
src/java/org/apache/nutch/crawl/CrawlDbReader.java.rej
patching file src/java/org/apache/nutch/crawl/LinkDb.java
patching file src/java/org/apache/nutch/crawl/CrawlDb.java
patching file src/java/org/apache/nutch/crawl/CrawlDbReader.java
Hunk #1 FAILED at 716.
1 out of 1 hunk FAILED -- saving rejects to file 
src/java/org/apache/nutch/crawl/CrawlDbReader.java.rej
patching file src/java/org/apache/nutch/crawl/DeduplicationJob.java
patching file src/java/org/apache/nutch/crawl/Generator.java
patching file src/java/org/apache/nutch/crawl/Injector.java
patching file src/java/org/apache/nutch/crawl/LinkDb.java
patching file src/java/org/apache/nutch/fetcher/Fetcher.java
patching file src/java/org/apache/nutch/parse/ParseSegment.java
patching file src/java/org/apache/nutch/service/ConfManager.java
patching file src/java/org/apache/nutch/service/JobManager.java
patching file src/java/org/apache/nutch/service/NutchServer.java
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED -- saving rejects to file 
src/java/org/apache/nutch/service/NutchServer.java.rej
patching file src/java/org/apache/nutch/service/impl/ConfManagerImpl.java
patching file src/java/org/apache/nutch/service/impl/JobFactory.java
patching file src/java/org/apache/nutch/service/impl/JobManagerImpl.java
patching file src/java/org/apache/nutch/service/impl/JobWorker.java
patching file 
src/java/org/apache/nutch/service/impl/NutchServerPoolExecutor.java
patching file src/java/org/apache/nutch/service/model/request/DbQuery.java
patching file src/java/org/apache/nutch/service/model/request/JobConfig.java
patching file src/java/org/apache/nutch/service/model/response/JobInfo.java
patching file src/java/org/apache/nutch/service/resources/AbstractResource.java
patching file src/java/org/apache/nutch/service/resources/ConfigResource.java
Hunk #1 FAILED at 38.
1 out of 1 hunk FAILED -- saving rejects to file 
src/java/org/apache/nutch/service/resources/ConfigResource.java.rej
patching file src/java/org/apache/nutch/service/resources/DbResource.java
patching file src/java/org/apache/nutch/util/NutchTool.java
patching file src/java/org/apache/nutch/crawl/CrawlDbReader.java
Hunk #2 FAILED at 797.
Hunk #3 FAILED at 808.
2 out of 3 hunks FAILED -- saving rejects to file 
src/java/org/apache/nutch/crawl/CrawlDbReader.java.rej
patching file src/java/org/apache/nutch/crawl/CrawlDb.java
patching file src/java/org/apache/nutch/crawl/CrawlDbReader.java
Hunk #1 FAILED at 720.
1 out of 1 hunk FAILED -- saving rejects to file 
src/java/org/apache/nutch/crawl/CrawlDbReader.java.rej
patching file src/java/org/apache/nutch/crawl/DeduplicationJob.java
patching file src/java/org/apache/nutch/crawl/Generator.java
patching file src/java/org/apache/nutch/crawl/Injector.java
patching file src/java/org/apache/nutch/crawl/LinkDb.java
patching file src/java/org/apache/nutch/fetcher/Fetcher.java
patching file src/java/org/apache/nutch/parse/ParseSegment.java
patching file src/java/org/apache/nutch/service/NutchServer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] n       
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file 
src/java/org/apache/nutch/service/NutchServer.java.rej
patching file src/java/org/apache/nutch/service/impl/JobWorker.java
patching file src/java/org/apache/nutch/service/model/request/DbQuery.java
patching file src/java/org/apache/nutch/service/resources/DbResource.java
patching file src/java/org/apache/nutch/util/NutchTool.java
[chipotle:~/tmp/nutch-1.10-trunk] mattmann% svn status
?       16.patch
M       src/java/org/apache/nutch/crawl/CrawlDb.java
M       src/java/org/apache/nutch/crawl/CrawlDbReader.java
?       src/java/org/apache/nutch/crawl/CrawlDbReader.java.orig
M       src/java/org/apache/nutch/crawl/DeduplicationJob.java
M       src/java/org/apache/nutch/crawl/Generator.java
M       src/java/org/apache/nutch/crawl/Injector.java
M       src/java/org/apache/nutch/crawl/LinkDb.java
M       src/java/org/apache/nutch/fetcher/Fetcher.java
M       src/java/org/apache/nutch/metadata/Nutch.java
M       src/java/org/apache/nutch/parse/ParseSegment.java
M       src/java/org/apache/nutch/service/ConfManager.java
M       src/java/org/apache/nutch/service/JobManager.java
M       src/java/org/apache/nutch/service/NutchServer.java
?       src/java/org/apache/nutch/service/NutchServer.java.orig
M       src/java/org/apache/nutch/service/impl/ConfManagerImpl.java
?       src/java/org/apache/nutch/service/impl/JobFactory.java
?       src/java/org/apache/nutch/service/impl/JobManagerImpl.java
?       src/java/org/apache/nutch/service/impl/JobWorker.java
?       src/java/org/apache/nutch/service/impl/NutchServerPoolExecutor.java
?       src/java/org/apache/nutch/service/model/request/DbQuery.java
?       src/java/org/apache/nutch/service/model/request/JobConfig.java
!       src/java/org/apache/nutch/service/model/response/JobConfig.java
M       src/java/org/apache/nutch/service/model/response/JobInfo.java
M       src/java/org/apache/nutch/service/resources/AbstractResource.java
?       src/java/org/apache/nutch/service/resources/ConfigResource.java.orig
?       src/java/org/apache/nutch/service/resources/DbResource.java
M       src/java/org/apache/nutch/service/resources/JobResource.java
?       src/java/org/apache/nutch/service/resources/JobResource.java.orig
?       src/java/org/apache/nutch/util/NutchTool.java
[chipotle:~/tmp/nutch-1.10-trunk] mattmann% 

{noformat}

Can you bring your pull request up to date with the latest trunk and then 
attach a patch?


> Job Administration end point for the REST service
> -------------------------------------------------
>
>                 Key: NUTCH-1973
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1973
>             Project: Nutch
>          Issue Type: Sub-task
>            Reporter: Sujen Shah
>            Assignee: Chris A. Mattmann
>
> This sub task deals with implementing the functionality documented at 
> https://wiki.apache.org/nutch/Nutch_1.X_RESTAPI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to