[
https://issues.apache.org/jira/browse/NUTCH-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681388#comment-14681388
]
Sebastian Nagel commented on NUTCH-2076:
----------------------------------------
Hi [~songwang], can you explain why the exceptions should be caught immediately
in the run() method? Afaics, the exceptions are properly caught and logged in
all calling methods:{{WebTableReader.run(String[] args)}} and
{{o.a.n.api.impl.JobWorker.run()}}.
> exceptions are not handled when using method waitForCompletion in a try block
> -----------------------------------------------------------------------------
>
> Key: NUTCH-2076
> URL: https://issues.apache.org/jira/browse/NUTCH-2076
> Project: Nutch
> Issue Type: Bug
> Components: crawldb
> Affects Versions: 2.2, 2.3
> Reporter: songwanging
> Priority: Minor
>
> Locations: src\java\org\apache\nutch\crawl\WebTableReader.java
> when using function waitForCompletion in a try block, exceptions are not
> handled :
> waitForCompletion might throw : IOException, InterruptedException,
> ClassNotFoundException
> so when calling this function in a try block, we should use a catch block to
> handle potential Exceptions.
> public Map<String, Object> run(Map<String, Object> args) throws Exception {
> ...
> try {
> currentJob.waitForCompletion(true);
> } finally {
> ToolUtil.recordJobStatus(null, currentJob, results);
> if (!currentJob.isSuccessful()) {
> fileSystem.delete(tmpFolder, true);
> return results;
> }
> }
> ...
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
