[ 
https://issues.apache.org/jira/browse/NUTCH-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711670#comment-14711670
 ] 

Kim Whitehall commented on NUTCH-2083:
--------------------------------------

Hey Lewis, 
Nicely done! 
I've got a few suggestions.
(1) make the following default  in the nutch-site.xml (or in 
src/plugin/lib-selenium/src/java/org/apache/nutch/protocol/selenium/HttpWebClient.java
 )
<property>
    <name>selenium.hub.port</name>
    <value>4444</value>
    <description>Selenium Hub Location connection port</description>
  </property>

  <property>
    <name>selenium.hub.path</name>
    <value>/wd/hub</value>
    <description>Selenium Hub Location connection path</description>
  </property>

  <property>
    <name>selenium.hub.host</name>
    <value>localhost</value>
    <description>Selenium Hub Location connection host</description>
  </property>

  <property>
    <name>selenium.hub.protocol</name>
    <value>http</value>
    <description>Selenium Hub Location connection protocol</description>
  </property>

(2) add the selenium-stand-alone server to the ivy file as indicated by Mo Omer 
@ https://github.com/momer/nutch-selenium-grid-plugin OR include in the 
instructions to obtain and start this on your own. It may also be prudent to 
mention here for person setting up the selenium grid, it is worthwhile to look 
into the node set up options to include maxSessions, nodeTimeOut and 
browserTimeOut options.   




> Implement functionality to shadow nutch-selenium-grid-plugin from Mo Omer
> -------------------------------------------------------------------------
>
>                 Key: NUTCH-2083
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2083
>             Project: Nutch
>          Issue Type: Improvement
>          Components: plugin
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>             Fix For: 1.11
>
>         Attachments: NUTCH-2083.patch
>
>
> This issue should augment the lib-selenium 
> src/plugin/lib-selenium/src/java/org/apache/nutch/protocol/selenium/HttpWebClient.java
>  and implement the same functionality as provided within [~momer]'s 
> [https://github.com/momer/nutch-selenium-grid-plugin|nutch-selenium-grid-plugin].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to