[ 
https://issues.apache.org/jira/browse/NUTCH-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804899#comment-14804899
 ] 

ASF GitHub Bot commented on NUTCH-2099:
---------------------------------------

Github user sujen1412 commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/59#discussion_r39821056
  
    --- Diff: src/java/org/apache/nutch/crawl/CrawlDb.java ---
    @@ -236,10 +237,10 @@ public int run(String[] args) throws Exception {
        * Used for Nutch REST service
        */
       @Override
    -  public Map<String, Object> run(Map<String, String> args, String crawlId) 
throws Exception {
    +  public Map<String, Object> run(Map<String, Object> args, String crawlId) 
throws Exception {
    --- End diff --
    
    @lewismc, making it object allows me to parse multiple inputs in the Map 
args(for ex- segments in the updatedb job) as an Arraylist instead of string 
parsing. Also this change the 1x code similar to 2x and also makes porting the 
webui easier as it expects an Object.


> Refactoring the REST endpoints for integration with webui
> ---------------------------------------------------------
>
>                 Key: NUTCH-2099
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2099
>             Project: Nutch
>          Issue Type: Sub-task
>          Components: REST_api, web gui
>            Reporter: Sujen Shah
>              Labels: memex
>             Fix For: 1.11
>
>
> This PR changes the structure of the arguments in the REST endpoints. Earlier 
> the args were accepted in a Map<String, String> form and now it is 
> Map<String, Object>. This is to allow Wicket to create the proper requests 
> objects and send it to NutchServer. 
> With the above, I have also added the metadata required for these services in 
> Nutch metadata.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to