Github user sebastian-nagel commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/89#discussion_r52833653
  
    --- Diff: src/java/org/apache/nutch/parse/ParseOutputFormat.java ---
    @@ -338,6 +340,9 @@ public static String filterNormalize(String fromUrl, 
String toUrl,
           } catch (MalformedURLException e1) {
             return null; // skip it
           }
    +
    +
    +
           if ("bydomain".equalsIgnoreCase(ignoreExternalLinksMode)) {
             String toDomain = URLUtil.getDomainName(targetURL).toLowerCase();
             if (toDomain == null || !toDomain.equals(origin)) {
    --- End diff --
    
    Shouldn't this case also be covered (db.ignore.external.links == true and 
db.ignore.external.links.mode == byDomain)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to